Fix code formatting and linting issues

- Auto-format all Python files with black and isort
- Remove unused imports with autoflake
- Fix flake8 issues (missing newlines, blank lines, etc.)
- Fix nonlocal/global scope issues in main.py
- Fix security.py import order (E402)
- Remove f-string without placeholders
- Add nosec comment for intentional exception handling
- Fix test imports to match refactored DMARCParser API

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-09 12:08:51 +00:00
parent f6908fe9ec
commit 6ae017b142
28 changed files with 999 additions and 956 deletions
+19 -18
View File
@@ -11,11 +11,12 @@ Implements various security headers to protect against common web vulnerabilitie
- Permissions-Policy
"""
import logging
from typing import Callable
from fastapi import Request
from starlette.middleware.base import BaseHTTPMiddleware
from starlette.responses import Response
from typing import Callable
import logging
logger = logging.getLogger(__name__)
@@ -24,31 +25,31 @@ class SecurityHeadersMiddleware(BaseHTTPMiddleware):
"""
Middleware to add security headers to all HTTP responses.
"""
def __init__(self, app, environment: str = "development"):
"""
Initialize security headers middleware.
Args:
app: FastAPI application instance
environment: Application environment (development/production)
"""
super().__init__(app)
self.environment = environment
async def dispatch(self, request: Request, call_next: Callable) -> Response:
"""
Process the request and add security headers to the response.
Args:
request: Incoming HTTP request
call_next: Next middleware/handler in the chain
Returns:
HTTP response with security headers added
"""
response = await call_next(request)
# Content Security Policy (CSP)
# Restricts sources of content that can be loaded
# TODO: Remove 'unsafe-inline' and 'unsafe-eval' and use nonces/hashes instead
@@ -64,26 +65,26 @@ class SecurityHeadersMiddleware(BaseHTTPMiddleware):
"connect-src 'self'",
"frame-ancestors 'none'", # Prevent framing
"base-uri 'self'",
"form-action 'self'"
"form-action 'self'",
]
response.headers["Content-Security-Policy"] = "; ".join(csp_directives)
# X-Frame-Options: Prevent clickjacking attacks
# 'DENY' prevents the page from being displayed in a frame
response.headers["X-Frame-Options"] = "DENY"
# X-Content-Type-Options: Prevent MIME type sniffing
# Forces browsers to respect the declared Content-Type
response.headers["X-Content-Type-Options"] = "nosniff"
# X-XSS-Protection: Enable browser XSS protection
# Note: Modern browsers rely more on CSP, but this provides defense-in-depth
response.headers["X-XSS-Protection"] = "1; mode=block"
# Referrer-Policy: Control referrer information
# 'strict-origin-when-cross-origin' provides good balance of privacy and functionality
response.headers["Referrer-Policy"] = "strict-origin-when-cross-origin"
# Permissions-Policy: Control browser features
# Disable features that aren't needed
permissions_policies = [
@@ -94,10 +95,10 @@ class SecurityHeadersMiddleware(BaseHTTPMiddleware):
"magnetometer=()",
"microphone=()",
"payment=()",
"usb=()"
"usb=()",
]
response.headers["Permissions-Policy"] = ", ".join(permissions_policies)
# Strict-Transport-Security (HSTS): Force HTTPS
# Only enable in production with HTTPS
if self.environment == "production":
@@ -107,12 +108,12 @@ class SecurityHeadersMiddleware(BaseHTTPMiddleware):
response.headers["Strict-Transport-Security"] = (
"max-age=31536000; includeSubDomains; preload"
)
# Cache-Control for sensitive pages
# Prevent caching of potentially sensitive data
if request.url.path.startswith("/api/"):
response.headers["Cache-Control"] = "no-store, no-cache, must-revalidate, private"
response.headers["Pragma"] = "no-cache"
response.headers["Expires"] = "0"
return response