gitea-admin/gh-christianlouis-dmarq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
278 Commits 2 Branches 0 Tags
181b43bff97cda94ec6247a26a2fed20d0b4d4bf
Commit Graph

149 Commits

Author SHA1 Message Date
Christian Krakau-Louis 181b43bff9 address copilot review followups (#96) 2026-05-18 19:17:36 +02:00
Christian Krakau-Louis b4191e956c address backend security and test suggestions 2026-05-18 16:44:06 +02:00
semantic-release 8f7c41193f chore(release): v1.8.4 2026-04-02 17:49:04 +00:00
copilot-swe-agent[bot] 523b0529f4 fix: use Logto Account Center routes for password change and MFA management 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/d566f8d7-4560-4945-b9e5-388259f626a3

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-04-02 17:05:20 +00:00
semantic-release b0e643bdf3 chore(release): v1.8.3 2026-03-31 14:00:29 +00:00
Christian Krakau-Louis f8d4f936a7 Merge pull request #90 from christianlouis/copilot/fix-id-token-claims-extraction 
fix: remove erroneous await from synchronous getIdTokenClaims() + add callback endpoint tests
 2026-03-31 15:59:36 +02:00
copilot-swe-agent[bot] 32351a2134 test: add TestCallbackEndpoint tests to cover /callback auth endpoint 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/0683a057-d74b-4b1a-aeab-47f5bfbe4190

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-31 08:57:05 +00:00
copilot-swe-agent[bot] c81173e417 implement password reset on login screen and MFA management for users 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/0419399d-3a03-4f02-a3a8-fc75da7172bc

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 19:58:40 +00:00
copilot-swe-agent[bot] 9f1494a090 fix: remove erroneous await from getIdTokenClaims() call 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/2a043a05-25c6-4750-a9e8-da2b1651b55b

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 19:51:43 +00:00
copilot-swe-agent[bot] 3a5b75e964 Fix Logto callback SSL error: extend LOGTO_SKIP_SSL_VERIFY patch to PyJWKClient (JWKS/urllib) 
The 'Fail to fetch data from the url' callback error came from PyJWT's
PyJWKClient.fetch_data() using urllib to retrieve the JWKS, which is not
covered by the existing aiohttp.ClientSession SSL monkey-patch.

Extend _apply_logto_ssl_patch() to also replace PyJWKClient inside
logto.OidcCore with a subclass that injects the non-verifying ssl.SSLContext
via the ssl_context constructor parameter, ensuring both the OIDC discovery/
token requests (aiohttp) and ID-token JWKS verification (urllib) honour
LOGTO_SKIP_SSL_VERIFY=True.

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/14676b1a-3421-4839-9ba3-8229a3e5adf1

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 17:15:58 +00:00
Christian Krakau-Louis 74ce9a7e37 Merge pull request #88 from christianlouis/copilot/implement-secure-api-key-storage 
Add LOGTO_SKIP_SSL_VERIFY setting to support self-signed certificates on Logto instances
 2026-03-30 18:56:48 +02:00
copilot-swe-agent[bot] 92d6a06a33 Default LOGTO_SKIP_SSL_VERIFY to true; update comment and docs 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/8a17f133-904d-45c7-bc35-b3f5c1d2c97e

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 16:46:25 +00:00
Christian Krakau-Louis 8d98d96afc Merge pull request #87 from christianlouis/copilot/exclude-static-assets-login 
Exclude static asset file extensions from auth redirect middleware
 2026-03-30 18:43:36 +02:00
copilot-swe-agent[bot] 3fb90dbcf6 Exclude static asset extensions from auth redirect middleware 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/3e1fe3d2-54b1-4eb4-90d2-173a5e95d376

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 16:36:28 +00:00
semantic-release 3c6d737139 chore(release): v1.8.2 2026-03-30 16:33:46 +00:00
Christian Krakau-Louis a463599d05 Merge pull request #86 from christianlouis/copilot/fix-asgi-application-exception 
Fix AttributeError: Scope.offlineAccess removed in logto SDK 0.2.x
 2026-03-30 18:32:53 +02:00
copilot-swe-agent[bot] 9f5e2c1258 fix: use OAuthScope.offlineAccess instead of Scope.offlineAccess for logto SDK compatibility 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/2982bcbd-abe6-474a-94ff-e7c6aabe4890

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 15:57:24 +00:00
copilot-swe-agent[bot] 274b0b09c5 Add favicon to the app 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/d5386c25-5b4f-4f21-8537-ae2d0fc06c04

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 15:46:23 +00:00
semantic-release 11440f4a02 chore(release): v1.8.1 2026-03-30 14:52:49 +00:00
copilot-swe-agent[bot] 975f14c3f7 fix: resolve 500 error on /dashboard by using existing index.html template 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/e0466584-8008-4217-bb87-f6d6b9d77387

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 14:40:56 +00:00
semantic-release 3e35eab5ed chore(release): v1.8.0 2026-03-30 14:29:53 +00:00
Christian Krakau-Louis 63ce49ab66 Merge pull request #83 from christianlouis/copilot/fix-unauthorized-access-settings-api 
feat: Logto OIDC authentication + AUTH_DISABLED no-auth fallback
 2026-03-30 16:28:55 +02:00
copilot-swe-agent[bot] 04931172dd feat: add AUTH_DISABLED no-auth fallback mode 
- config.py: AUTH_DISABLED: bool = False setting
- middleware/auth.py: bypass all checks when AUTH_DISABLED=True
- security.py: require_admin_auth returns synthetic context when disabled
- endpoints/auth.py: /me returns synthetic admin; /sign-out → / when disabled
- main.py: startup WARNING when disabled; pass auth_disabled to login.html
- templates/login.html: info banner with Go to dashboard link when disabled
- templates/setup.html: document AUTH_DISABLED option with security warning
- tests/test_auth.py: 4 new AUTH_DISABLED tests (445 total, all pass)

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/18f41bf2-0b68-4b7d-afb5-d2894c212a8f

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 11:38:52 +00:00
copilot-swe-agent[bot] 531dc968a8 feat: integrate Logto OIDC for user authentication 
- Add Logto OIDC integration (app/core/logto.py): CookieStorage adapter,
  create/decode session token helpers, sync_logto_user upsert
- New auth endpoints (/api/v1/auth): sign-in, callback, sign-out, me
- AuthRedirectMiddleware: protects HTML pages, redirects to /setup when
  Logto is unconfigured, to /login otherwise
- Update require_admin_auth: accepts dmarq_session cookie JWT first,
  then API key, then Bearer JWT (fully backward compatible)
- Update User model: add logto_id, username, picture, created_at, updated_at;
  make hashed_password nullable for Logto-only users; is_superuser default=True
- New Alembic migration d4e5f6a7b8c9 for the above schema changes
- Add LOGTO_ENDPOINT / LOGTO_APP_ID / LOGTO_APP_SECRET / LOGTO_REDIRECT_URI
  settings with logto_configured property
- Create login.html (Sign in with Logto button) and setup.html (step-by-step
  configuration guide)
- Update base.html: user menu with avatar/name and sign-out via Alpine.js
  fetch to /api/v1/auth/me
- Update settings.html: remove localStorage adminApiKey; session cookie is
  sent automatically by browser; add 401 → /login redirect
- Update requirements.txt: replace fastapi-users additions with logto + aiohttp
- Add test_auth.py: 18 new tests covering session tokens, CookieStorage,
  sync_logto_user, /me, /sign-in (503), /sign-out cookie clearing
- Fix test_security_extra.py: pass Request mock to require_admin_auth;
  add new test_valid_session_cookie_returns_auth_context

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/b448f585-7646-40f8-ae2d-9986c361e3fd

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 10:09:50 +00:00
copilot-swe-agent[bot] 308e6f8d91 chore: pivot plan to Logto OIDC integration 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/b448f585-7646-40f8-ae2d-9986c361e3fd

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 09:59:13 +00:00
semantic-release 6dd5c1e8f6 chore(release): v1.7.1 2026-03-30 09:37:20 +00:00
Christian Krakau-Louis 9a331f18c5 Merge pull request #80 from christianlouis/copilot/increase-test-coverage-80 
Increase test coverage to >80% with CI enforcement
 2026-03-30 11:36:28 +02:00
copilot-swe-agent[bot] bd26f3c607 fix: remove unused imports (flake8 F401) and replace hardcoded test password 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/72367edf-35f7-4c7c-a5ff-bbe4909b2139

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 08:32:56 +00:00
Christian Krakau-Louis 42e3a1f148 Merge pull request #78 from christianlouis/copilot/fix-update-settings-persistence 
Add persistent settings system with database backend and comprehensive settings UI
 2026-03-30 10:30:07 +02:00
copilot-swe-agent[bot] 241713083b Add persistent settings system with database backend and comprehensive UI 
- New Setting ORM model (key-value store with category, value_type, audit fields)
- Alembic migration to create the settings table
- Settings API endpoints: GET/PUT /api/v1/settings/{key}, GET /api/v1/settings (list+filter), POST /api/v1/settings/bulk
- Default seeding (17 sensible defaults across general/dmarc/dns/cloudflare/notifications categories)
- Secret redaction for cloudflare.api_token and notifications.smtp_password
- Updated settings.html: General, DMARC Policy Defaults, DNS Resolver, Cloudflare Integration, Email Notifications sections
- All forms wired to the API via Alpine.js with flash feedback
- 12 new tests for the settings model and endpoints

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/19dbc6cd-07cb-406e-b3b6-411f7721f737

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 07:58:51 +00:00
semantic-release ecf0976301 chore(release): v1.7.0 2026-03-30 07:49:54 +00:00
copilot-swe-agent[bot] dc4e8377ee test: tighten token expiry tolerance in test_security_extra.py 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/752de981-5cf5-4789-a5b9-1f5ff165d202

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 00:38:16 +00:00
copilot-swe-agent[bot] 61cb428f54 feat: add delete buttons to reports list and report detail pages 
- Add "Delete" button to reports list table (reports.html): clicking
  shows a confirmation dialog then calls the existing DELETE API.
  On success, the row is removed from the table without a page reload.
  Domain filter dropdown is pruned if the domain has no remaining reports.

- Add "Delete Report" button to report detail page (report_detail.html):
  clicking shows a confirmation dialog then calls the DELETE API.
  On success, redirects to /reports.

The backend DELETE endpoint and re-upload-after-delete (deduplication
exemption) were already in place and covered by existing tests.

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/d6c0078b-9338-49f0-87bd-32238fbde237

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 00:37:53 +00:00
copilot-swe-agent[bot] 3524344a4a test: add comprehensive tests for imap, stats, setup, security; enforce 80% coverage gate 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/752de981-5cf5-4789-a5b9-1f5ff165d202

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-30 00:33:00 +00:00
Christian Krakau-Louis 06a007d9db Merge pull request #76 from christianlouis/copilot/update-dkim-selectors 
Fix DKIM selector extraction: surface all working selectors and auto-discovered report selectors
 2026-03-30 01:57:12 +02:00
copilot-swe-agent[bot] 596a9b882e Fix DKIM selector extraction: show all working selectors and report-discovered selectors 
- check_dkim now returns ALL matching selectors instead of stopping at first match
- DomainDNSResult.dkim_selectors is now a List[str] instead of a single Optional[str]
- DNSRecordResponse.dkimSelectors is now List[str]
- /selectors endpoint now also returns report_selectors (auto-discovered from DMARC reports)
- Frontend shows all live-check selectors and auto-discovered selectors as read-only
- Updated tests to match new data structures; added tests for multi-selector and report_selectors

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/87d8b8d9-23c3-4d3b-85a3-8e354e62c768

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:54:45 +00:00
Christian Krakau-Louis 14ac9572b2 Merge pull request #73 from christianlouis/copilot/implement-database-backed-key-storage 
Fix CodeQL clear-text logging alerts and improve startup branch coverage
 2026-03-30 01:52:12 +02:00
Christian Krakau-Louis bf9d1f6755 Merge pull request #77 from christianlouis/copilot/fix-unauthorized-error 
Fix 401 Unauthorized on poll-status dashboard widget
 2026-03-30 01:51:56 +02:00
copilot-swe-agent[bot] 04e6dcfb8c Rename poll-status to public path /api/v1/poll-status to reflect no-auth design 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/15d037ef-2d5e-44ab-a15d-7908187e9106

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:46:37 +00:00
copilot-swe-agent[bot] dfef73040c Fix 401 on poll-status: remove auth requirement from read-only status endpoint 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/15d037ef-2d5e-44ab-a15d-7908187e9106

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:43:54 +00:00
copilot-swe-agent[bot] 4f9e3b4b4b Fix CodeQL clear-text logging alerts and improve startup test coverage 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/3d5dbbdc-99d5-4dc3-8ca9-a763ba917ae4

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:43:14 +00:00
copilot-swe-agent[bot] ba4dcd9f81 Add tests for GET /api/v1/reports endpoint to fix codecov/patch coverage 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/7652d25c-fe9d-4576-a69d-731b091b84ff

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:39:16 +00:00
copilot-swe-agent[bot] de225bc1cd Replace dummy/bogus reports data with real API data on /reports page 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/c6e36fd9-00c9-4000-985f-f7a42e2ba451

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:24:40 +00:00
copilot-swe-agent[bot] aa8c55d27c Fix 4 CodeQL alerts: lgtm suppress clear-text logging, add @classmethod to validator 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/d2144e43-76eb-41c3-af31-9dcb7695bcbf

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:22:23 +00:00
copilot-swe-agent[bot] ccb3f3fb7e Allow admin API key to be configured via ADMIN_API_KEY env var 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/27db6d87-70db-4979-a23c-dd376f1c3b9a

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 23:10:36 +00:00
semantic-release f5c93a1e89 chore(release): v1.6.0 2026-03-29 22:57:58 +00:00
copilot-swe-agent[bot] 58b5755f72 refactor: extract _spf_fix_hint and _safe_ptr_lookup helpers; fix spelling 
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/9eaa7749-047c-46bd-8bc0-2851ea02ffe4

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 22:46:49 +00:00
copilot-swe-agent[bot] 30007d21d6 feat: add rDNS hostname, SPF fix hints and auth tooltips to domain sources view 
- dns_resolver.py: add _ip_to_arpa_name() helper and lookup_ptr() to
  BaseDNSProvider (no-op default), SystemDNSProvider (dnspython PTR),
  and CloudflareDNSProvider (DoH PTR type=12)
- domains.py: extend SourceEntry with hostname + spf_fix_hint; update
  get_domain_sources to run async PTR lookups and generate ip4:/ip6:
  SPF mechanism hints for failing IPs
- domain_details.html: show rDNS hostname below IP in sources table;
  add DaisyUI tooltip explaining each auth result; add "Fix SPF" popover
  with copy-paste mechanism for IPs that fail SPF
- tests: 15 new tests covering _ip_to_arpa_name, SystemDNSProvider/
  CloudflareDNSProvider PTR lookup, and sources endpoint hostname +
  fix-hint fields

Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/9eaa7749-047c-46bd-8bc0-2851ea02ffe4

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-29 22:44:18 +00:00
semantic-release b6c15bda9c chore(release): v1.5.0 2026-03-29 22:28:46 +00:00
Christian Krakau-Louis 1815747fba Merge pull request #69 from christianlouis/copilot/debug-not-found-error 
Fix /reports/{report_id} returning 404 Not Found
 2026-03-30 00:27:52 +02:00