copilot-swe-agent[bot]
70dc77011a
Agent-Logs-Url: https://github.com/christianlouis/dmarq/sessions/d1890838-1770-4d5f-886f-f210df761fae Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
99 lines
4.1 KiB
Python
99 lines
4.1 KiB
Python
"""
|
|
Tests for application settings / config.py.
|
|
|
|
Covers BACKEND_CORS_ORIGINS parsing including the empty-string case that
|
|
previously caused a JSONDecodeError in pydantic_settings v2 before validators
|
|
could run (see: pydantic_settings sources/providers/env.py decode_complex_value).
|
|
"""
|
|
|
|
from app.core.config import Settings
|
|
from app.core.database import _make_sync_db_url
|
|
|
|
|
|
class TestBackendCorsOriginsValidator:
|
|
"""Tests for the assemble_cors_origins validator."""
|
|
|
|
def test_comma_separated_string(self):
|
|
"""Comma-separated origins are split into a list."""
|
|
settings = Settings(BACKEND_CORS_ORIGINS="http://localhost:3000,http://localhost:5173")
|
|
assert settings.BACKEND_CORS_ORIGINS == [
|
|
"http://localhost:3000",
|
|
"http://localhost:5173",
|
|
]
|
|
|
|
def test_single_origin_string(self):
|
|
"""A single origin as a string is wrapped in a list."""
|
|
settings = Settings(BACKEND_CORS_ORIGINS="https://example.com")
|
|
assert settings.BACKEND_CORS_ORIGINS == ["https://example.com"]
|
|
|
|
def test_empty_string_returns_empty_list(self):
|
|
"""An empty string must not raise JSONDecodeError; returns an empty list."""
|
|
settings = Settings(BACKEND_CORS_ORIGINS="")
|
|
assert settings.BACKEND_CORS_ORIGINS == []
|
|
|
|
def test_whitespace_only_string_returns_empty_list(self):
|
|
"""A whitespace-only string is treated the same as empty."""
|
|
settings = Settings(BACKEND_CORS_ORIGINS=" ")
|
|
assert settings.BACKEND_CORS_ORIGINS == []
|
|
|
|
def test_list_passthrough(self):
|
|
"""A list value is passed through unchanged."""
|
|
origins = ["https://a.example.com", "https://b.example.com"]
|
|
settings = Settings(BACKEND_CORS_ORIGINS=origins)
|
|
assert settings.BACKEND_CORS_ORIGINS == origins
|
|
|
|
def test_default_when_not_provided(self):
|
|
"""Defaults are returned when BACKEND_CORS_ORIGINS is not set."""
|
|
settings = Settings()
|
|
assert "http://localhost:3000" in settings.BACKEND_CORS_ORIGINS
|
|
assert "http://localhost:5173" in settings.BACKEND_CORS_ORIGINS
|
|
|
|
def test_comma_separated_with_spaces(self):
|
|
"""Extra whitespace around origins is stripped."""
|
|
settings = Settings(BACKEND_CORS_ORIGINS=" http://a.example.com , http://b.example.com ")
|
|
assert settings.BACKEND_CORS_ORIGINS == [
|
|
"http://a.example.com",
|
|
"http://b.example.com",
|
|
]
|
|
|
|
def test_json_array_string(self):
|
|
"""A JSON array string is parsed into a list."""
|
|
settings = Settings(
|
|
BACKEND_CORS_ORIGINS='["https://a.example.com", "https://b.example.com"]'
|
|
)
|
|
assert settings.BACKEND_CORS_ORIGINS == [
|
|
"https://a.example.com",
|
|
"https://b.example.com",
|
|
]
|
|
|
|
|
|
class TestMakeSyncDbUrl:
|
|
"""Tests for the _make_sync_db_url() URL normalization helper."""
|
|
|
|
def test_asyncpg_replaced_with_psycopg2(self):
|
|
"""asyncpg scheme is converted to psycopg2."""
|
|
url = "postgresql+asyncpg://user:pass@db:5432/mydb"
|
|
assert _make_sync_db_url(url) == "postgresql+psycopg2://user:pass@db:5432/mydb"
|
|
|
|
def test_plain_postgresql_unchanged(self):
|
|
"""Plain postgresql:// URLs are not modified."""
|
|
url = "postgresql://user:pass@db:5432/mydb"
|
|
assert _make_sync_db_url(url) == url
|
|
|
|
def test_psycopg2_url_unchanged(self):
|
|
"""URLs already using psycopg2 are not modified."""
|
|
url = "postgresql+psycopg2://user:pass@db:5432/mydb"
|
|
assert _make_sync_db_url(url) == url
|
|
|
|
def test_sqlite_url_unchanged(self):
|
|
"""SQLite URLs are not modified."""
|
|
url = "sqlite:///./dmarq.db"
|
|
assert _make_sync_db_url(url) == url
|
|
|
|
def test_database_url_setting_asyncpg(self):
|
|
"""Settings with an asyncpg DATABASE_URL still initialise correctly."""
|
|
settings = Settings(DATABASE_URL="postgresql+asyncpg://user:pass@db:5432/mydb")
|
|
assert settings.DATABASE_URL == "postgresql+asyncpg://user:pass@db:5432/mydb"
|
|
# Normalised URL used by the engine must not contain asyncpg
|
|
assert "asyncpg" not in _make_sync_db_url(settings.DATABASE_URL)
|