Address code review feedback

- Clarify test expectations for auth-disabled environment
- Skip timestamp update test (DB backend dependent)
- Document require_admin_access sync/async support
- Restore session_secret and external_hostname as required
- Add comments explaining validation and security requirements

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-08 06:09:23 +00:00
parent 8afddbc75b
commit 02fa9ccde4
3 changed files with 27 additions and 16 deletions
+2 -2
View File
@@ -48,7 +48,7 @@ SETTING_METADATA = {
"description": "External hostname for the application (e.g., docuelevate.example.com)",
"type": "string",
"sensitive": False,
"required": False,
"required": True, # Required for OAuth redirects and external URLs
"restart_required": True,
},
"debug": {
@@ -82,7 +82,7 @@ SETTING_METADATA = {
"description": "Secret key for session encryption (min 32 characters)",
"type": "string",
"sensitive": True,
"required": False,
"required": True, # Required when auth_enabled=True (validated in config.py)
"restart_required": True,
},
"admin_username": {