fix(ui): address code review feedback on complimentary badge and aria attributes
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
@@ -143,10 +143,9 @@
|
|||||||
<span
|
<span
|
||||||
x-show="user.is_complimentary"
|
x-show="user.is_complimentary"
|
||||||
class="ml-1 inline-flex items-center gap-1 px-2 py-0.5 rounded-full text-xs font-semibold bg-green-100 text-green-700"
|
class="ml-1 inline-flex items-center gap-1 px-2 py-0.5 rounded-full text-xs font-semibold bg-green-100 text-green-700"
|
||||||
title="Complimentary — not billed"
|
aria-label="Complimentary plan — not billed"
|
||||||
>
|
>
|
||||||
<i class="fas fa-gift" aria-hidden="true"></i>
|
<i class="fas fa-gift" aria-hidden="true"></i>
|
||||||
<span class="sr-only">Complimentary plan</span>
|
|
||||||
</span>
|
</span>
|
||||||
</td>
|
</td>
|
||||||
<!-- Upload limit -->
|
<!-- Upload limit -->
|
||||||
@@ -392,7 +391,7 @@
|
|||||||
class="sr-only peer"
|
class="sr-only peer"
|
||||||
id="modal-complimentary"
|
id="modal-complimentary"
|
||||||
role="switch"
|
role="switch"
|
||||||
:aria-checked="form.is_complimentary"
|
:aria-checked="form.is_complimentary.toString()"
|
||||||
/>
|
/>
|
||||||
<div class="w-10 h-6 bg-gray-200 peer-focus:ring-2 peer-focus:ring-blue-400 rounded-full peer peer-checked:bg-green-500 after:content-[''] after:absolute after:top-[2px] after:left-[2px] after:bg-white after:rounded-full after:h-5 after:w-5 after:transition-all peer-checked:after:translate-x-4"></div>
|
<div class="w-10 h-6 bg-gray-200 peer-focus:ring-2 peer-focus:ring-blue-400 rounded-full peer peer-checked:bg-green-500 after:content-[''] after:absolute after:top-[2px] after:left-[2px] after:bg-white after:rounded-full after:h-5 after:w-5 after:transition-all peer-checked:after:translate-x-4"></div>
|
||||||
</label>
|
</label>
|
||||||
|
|||||||
@@ -621,7 +621,7 @@ class TestEnsureUserProfileAdmin:
|
|||||||
|
|
||||||
@pytest.mark.unit
|
@pytest.mark.unit
|
||||||
def test_admin_login_does_not_downgrade_existing_tier(self, au_session):
|
def test_admin_login_does_not_downgrade_existing_tier(self, au_session):
|
||||||
"""Existing admin profile with a paid tier keeps that tier on re-login."""
|
"""Existing admin profile with the highest tier keeps that tier on re-login."""
|
||||||
from app.auth import _ensure_user_profile
|
from app.auth import _ensure_user_profile
|
||||||
from app.utils.subscription import TIER_ORDER
|
from app.utils.subscription import TIER_ORDER
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user