fix(sharing): address code review: fix default role, auto-share logic, aria labels

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com> Agent-Logs-Url: https://github.com/christianlouis/DocuElevate/sessions/8091889d-4810-4794-b9d3-6b8f7f5257c4
2026-03-22 14:22:35 +00:00
parent 6f2752bdf8
commit 124b802c8f
5 changed files with 149 additions and 6 deletions
@@ -264,8 +264,9 @@ def create_comment(

            if _settings.multi_user_enabled:
                for mentioned_user in mentions:
-                    # Skip the commenter themselves and the file owner
-                    if mentioned_user in (owner_id, file_record.owner_id):
+                    # Skip the file owner (already has full access) and the commenter
+                    # themselves (they already have access to be posting a comment).
+                    if mentioned_user in {file_record.owner_id, owner_id}:
                        continue
                    existing_share = (
                        db.query(FileShare)