fix(sharing): address code review: fix default role, auto-share logic, aria labels

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
Agent-Logs-Url: https://github.com/christianlouis/DocuElevate/sessions/8091889d-4810-4794-b9d3-6b8f7f5257c4

frontend/static/js/sharing.js

@@ -103,7 +103,9 @@
       var roleLabel = s.role === 'editor' ? _t('role_editor') : _t('role_viewer');
       return (
         '<div style="display:flex;align-items:center;justify-content:space-between;gap:0.5rem;padding:0.5rem 0;border-bottom:1px solid #f1f5f9;">' +
-          '<span style="font-size:0.875rem;color:#334155;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;flex:1;" title="' + _esc(s.user_id) + '">' +
+          '<span style="font-size:0.875rem;color:#334155;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;flex:1;" ' +
+            'aria-label="' + _esc(_t('user_id_label') + ': ' + (s.display_name || s.user_id)) + '" ' +
+            'title="' + _esc(s.user_id) + '">' +
             _esc(s.display_name || s.user_id) +
           '</span>' +
           '<select' +

frontend/templates/file_annotations.html

@@ -686,7 +686,6 @@
             id="share-user-input"
             placeholder="{{ _('sharing.user_id_placeholder') }}"
             style="width:100%;padding:0.5rem 0.75rem;border:1px solid #cbd5e1;border-radius:0.375rem;font-size:0.875rem;"
-            aria-label="{{ _('sharing.user_id_label') }}"
           />
         </div>
         <div style="min-width:120px;">
@@ -696,7 +695,6 @@
           <select
             id="share-role-input"
             style="width:100%;padding:0.5rem 0.75rem;border:1px solid #cbd5e1;border-radius:0.375rem;font-size:0.875rem;background:#fff;"
-            aria-label="{{ _('sharing.role_label') }}"
           >
             <option value="viewer">{{ _("sharing.role_viewer") }}</option>
             <option value="editor">{{ _("sharing.role_editor") }}</option>