gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(test): remove incorrect mock_task argument from __wrapped__ calls in test_extract_metadata_gpt.py

Browse Source 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-12 12:48:56 +00:00
parent b00610d7de
commit 1381f8bad0
1 changed files with 19 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_extract_metadata_gpt.py
+19 -29
View File
@@ -1,7 +1,7 @@
"""Comprehensive unit tests for app/tasks/extract_metadata_with_gpt.py module.""" """Comprehensive unit tests for app/tasks/extract_metadata_with_gpt.py module."""
import json import json
from unittest.mock import MagicMock, Mock, patch from unittest.mock import MagicMock, patch
import pytest import pytest
@@ -89,12 +89,11 @@ class TestExtractMetadataWithGpt:
}) })
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
# Mock the task context # Set task request context directly on the Celery task
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
# Call the underlying function directly (not through Celery) # Call the underlying function directly (not through Celery)
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test_invoice.pdf", "Invoice from Amazon for 99.99 EUR", 123) result = extract_metadata_with_gpt.__wrapped__("test_invoice.pdf", "Invoice from Amazon for 99.99 EUR", 123)
# Verify OpenAI was called # Verify OpenAI was called
mock_client.chat.completions.create.assert_called_once() mock_client.chat.completions.create.assert_called_once()
@@ -123,10 +122,9 @@ class TestExtractMetadataWithGpt:
mock_completion.choices[0].message.content = '```json\n{"filename": "test.pdf", "document_type": "Unknown"}\n```' mock_completion.choices[0].message.content = '```json\n{"filename": "test.pdf", "document_type": "Unknown"}\n```'
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 456) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 456)
assert result["metadata"]["filename"] == "test.pdf" assert result["metadata"]["filename"] == "test.pdf"
assert result["metadata"]["document_type"] == "Unknown" assert result["metadata"]["document_type"] == "Unknown"
@@ -141,10 +139,9 @@ class TestExtractMetadataWithGpt:
mock_completion.choices[0].message.content = "This is not valid JSON at all" mock_completion.choices[0].message.content = "This is not valid JSON at all"
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 789) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 789)
assert result == {} assert result == {}
mock_embed_task.delay.assert_not_called() mock_embed_task.delay.assert_not_called()
@@ -159,10 +156,9 @@ class TestExtractMetadataWithGpt:
"""Test handling of OpenAI API exceptions.""" """Test handling of OpenAI API exceptions."""
mock_client.chat.completions.create.side_effect = Exception("API Error: Rate limit exceeded") mock_client.chat.completions.create.side_effect = Exception("API Error: Rate limit exceeded")
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 101) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 101)
assert result == {} assert result == {}
mock_embed_task.delay.assert_not_called() mock_embed_task.delay.assert_not_called()
@@ -192,11 +188,9 @@ class TestExtractMetadataWithGpt:
# Mock file existence # Mock file existence
with patch("app.tasks.extract_metadata_with_gpt.os.path.exists", return_value=True): with patch("app.tasks.extract_metadata_with_gpt.os.path.exists", return_value=True):
with patch("app.tasks.extract_metadata_with_gpt.settings.workdir", "/tmp"): with patch("app.tasks.extract_metadata_with_gpt.settings.workdir", "/tmp"):
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__( result = extract_metadata_with_gpt.__wrapped__(
mock_task,
filename="test.pdf", filename="test.pdf",
cleaned_text="Sample text", cleaned_text="Sample text",
file_id=None # Not provided file_id=None # Not provided
@@ -219,10 +213,9 @@ class TestExtractMetadataWithGpt:
}) })
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 202) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 202)
# Filename should be sanitized (empty or safe) # Filename should be sanitized (empty or safe)
assert result["metadata"]["filename"] == "" assert result["metadata"]["filename"] == ""
@@ -240,10 +233,9 @@ class TestExtractMetadataWithGpt:
}) })
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 303) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 303)
# Filename with .. should be rejected # Filename with .. should be rejected
assert result["metadata"]["filename"] == "" assert result["metadata"]["filename"] == ""
@@ -260,10 +252,9 @@ class TestExtractMetadataWithGpt:
}) })
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 404) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 404)
# Valid filename should be preserved # Valid filename should be preserved
assert result["metadata"]["filename"] == "2024-01-15_Invoice_Amazon.pdf" assert result["metadata"]["filename"] == "2024-01-15_Invoice_Amazon.pdf"
@@ -277,10 +268,9 @@ class TestExtractMetadataWithGpt:
mock_completion.choices[0].message.content = '{"unexpected_field": "value"}' mock_completion.choices[0].message.content = '{"unexpected_field": "value"}'
mock_client.chat.completions.create.return_value = mock_completion mock_client.chat.completions.create.return_value = mock_completion
mock_task = MagicMock() extract_metadata_with_gpt.request.id = "test-task-id"
mock_task.request.id = "test-task-id"
result = extract_metadata_with_gpt.__wrapped__(mock_task, "test.pdf", "Sample text", 505) result = extract_metadata_with_gpt.__wrapped__("test.pdf", "Sample text", 505)
# Should still extract the JSON even if fields are unexpected # Should still extract the JSON even if fields are unexpected
assert "metadata" in result assert "metadata" in result