test(views): add user-mode coverage tests and fix dashboard helper duplication
- Add tests for user-mode with invalid JSON config (covers exception handling path) - Add tests for user-mode with valid config (verifies folder path pre-population) - Extract _watchFolderOAuthSource() helper to reduce isOAuthType/oauthLink duplication Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
@@ -1,7 +1,12 @@
|
||||
"""Tests for app/views/onedrive.py module."""
|
||||
|
||||
import json
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
from app.models import UserIntegration
|
||||
|
||||
|
||||
@pytest.mark.integration
|
||||
class TestOnedriveViews:
|
||||
@@ -42,3 +47,47 @@ class TestOnedriveViews:
|
||||
body = response.text
|
||||
assert "oauth_integration_id" in body
|
||||
assert 'const integrationId = ""' in body
|
||||
|
||||
def test_onedrive_setup_user_mode_invalid_json_config(self, client, db_session):
|
||||
"""Test user-mode renders correctly when integration.config is invalid JSON."""
|
||||
owner_id = "user_od_invalid_json@example.com"
|
||||
integration = UserIntegration(
|
||||
owner_id=owner_id,
|
||||
direction="DESTINATION",
|
||||
integration_type="ONEDRIVE",
|
||||
name="My OneDrive (bad cfg)",
|
||||
config="{INVALID JSON}",
|
||||
is_active=True,
|
||||
)
|
||||
db_session.add(integration)
|
||||
db_session.commit()
|
||||
db_session.refresh(integration)
|
||||
|
||||
with patch("app.views.onedrive.get_current_owner_id", return_value=owner_id):
|
||||
response = client.get(f"/onedrive-setup?integration_id={integration.id}")
|
||||
|
||||
assert response.status_code == 200
|
||||
# Should render user mode without errors despite the bad config
|
||||
assert b"Back to Integrations" in response.content
|
||||
|
||||
def test_onedrive_setup_user_mode_valid_config(self, client, db_session):
|
||||
"""Test user-mode correctly loads folder path from integration config."""
|
||||
owner_id = "user_od_valid_cfg@example.com"
|
||||
integration = UserIntegration(
|
||||
owner_id=owner_id,
|
||||
direction="DESTINATION",
|
||||
integration_type="ONEDRIVE",
|
||||
name="My OneDrive",
|
||||
config=json.dumps({"folder_path": "Documents/Archive"}),
|
||||
is_active=True,
|
||||
)
|
||||
db_session.add(integration)
|
||||
db_session.commit()
|
||||
db_session.refresh(integration)
|
||||
|
||||
with patch("app.views.onedrive.get_current_owner_id", return_value=owner_id):
|
||||
response = client.get(f"/onedrive-setup?integration_id={integration.id}")
|
||||
|
||||
assert response.status_code == 200
|
||||
assert b"Documents/Archive" in response.content
|
||||
assert b"Back to Integrations" in response.content
|
||||
|
||||
Reference in New Issue
Block a user