Merge pull request #713 from christianlouis/perf/fix-notifications-api-n-plus-1-17980566457111073264

⚡ Fix N+1 Query in Notification Preferences Update
2026-03-16 10:46:12 +01:00
parent 1102a495e5 fa9b037d5a
commit 3088459c70
3 changed files with 114 additions and 10 deletions
@@ -452,17 +452,16 @@ async def update_preferences(
            )

    try:
+        # Pre-fetch existing preferences for this user to avoid N+1 queries
+        existing_prefs = (
+            db.query(UserNotificationPreference).filter(UserNotificationPreference.owner_id == owner_id).all()
+        )
+
+        # Build a fast lookup dictionary keyed by (event_type, channel_type, target_id)
+        prefs_dict = {(pref.event_type, pref.channel_type, pref.target_id): pref for pref in existing_prefs}
+
        for item in body.preferences:
-            existing = (
-                db.query(UserNotificationPreference)
-                .filter(
-                    UserNotificationPreference.owner_id == owner_id,
-                    UserNotificationPreference.event_type == item.event_type,
-                    UserNotificationPreference.channel_type == item.channel_type,
-                    UserNotificationPreference.target_id == item.target_id,
-                )
-                .first()
-            )
+            existing = prefs_dict.get((item.event_type, item.channel_type, item.target_id))
            if existing:
                existing.is_enabled = item.is_enabled
            else: