feat: add strict mypy type-checking for app/utils/ module
- Add [[tool.mypy.overrides]] section for app/utils/** with disallow_untyped_defs=true - Add type annotations to all functions in app/utils/ (12 files) - Fix type annotations in app/config.py and app/database.py (imported by utils) - All 85 source files now pass mypy type checking Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
@@ -3,7 +3,7 @@ Module for masking sensitive information in configuration values
|
||||
"""
|
||||
|
||||
|
||||
def mask_sensitive_value(value):
|
||||
def mask_sensitive_value(value: str | None) -> str | None:
|
||||
"""
|
||||
Masks sensitive values like API keys in logs and output
|
||||
"""
|
||||
|
||||
@@ -6,7 +6,7 @@ from app.config import settings
|
||||
from app.utils.config_validator.masking import mask_sensitive_value
|
||||
|
||||
|
||||
def get_provider_status():
|
||||
def get_provider_status() -> dict[str, dict[str, object]]:
|
||||
"""
|
||||
Returns status information for all configured providers
|
||||
"""
|
||||
|
||||
@@ -13,7 +13,7 @@ logger = logging.getLogger(__name__)
|
||||
_PYDANTIC_INTERNALS = {"model_computed_fields", "model_config", "model_extra", "model_fields", "model_fields_set"}
|
||||
|
||||
|
||||
def dump_all_settings():
|
||||
def dump_all_settings() -> None:
|
||||
"""Log all settings values for diagnostic purposes"""
|
||||
logger.info("--- DUMPING ALL SETTINGS FOR DIAGNOSTIC PURPOSES ---")
|
||||
for key in dir(settings):
|
||||
@@ -60,7 +60,7 @@ def dump_all_settings():
|
||||
logger.info("--- END OF SETTINGS DUMP ---")
|
||||
|
||||
|
||||
def get_settings_for_display(show_values=False):
|
||||
def get_settings_for_display(show_values: bool = False) -> dict[str, list[dict[str, object]]]:
|
||||
"""
|
||||
Group settings into logical categories and check if they are configured.
|
||||
Returns a dictionary with categories as keys and lists of setting items as values.
|
||||
|
||||
@@ -9,7 +9,7 @@ from app.config import settings
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
|
||||
def validate_email_config():
|
||||
def validate_email_config() -> list[str]:
|
||||
"""Validates email configuration settings"""
|
||||
issues = []
|
||||
|
||||
@@ -36,7 +36,7 @@ def validate_email_config():
|
||||
return issues
|
||||
|
||||
|
||||
def validate_auth_config():
|
||||
def validate_auth_config() -> list[str]:
|
||||
"""Validates authentication configuration settings"""
|
||||
issues = []
|
||||
|
||||
@@ -69,7 +69,7 @@ def validate_auth_config():
|
||||
return issues
|
||||
|
||||
|
||||
def validate_storage_configs():
|
||||
def validate_storage_configs() -> dict[str, list[str]]:
|
||||
"""Validates configuration for all storage providers"""
|
||||
issues = {}
|
||||
|
||||
@@ -178,7 +178,7 @@ def validate_storage_configs():
|
||||
return issues
|
||||
|
||||
|
||||
def validate_notification_config():
|
||||
def validate_notification_config() -> list[str]:
|
||||
"""Check notification configuration"""
|
||||
issues = []
|
||||
|
||||
@@ -210,7 +210,7 @@ def validate_notification_config():
|
||||
return issues
|
||||
|
||||
|
||||
def check_all_configs():
|
||||
def check_all_configs() -> dict[str, list[str] | dict[str, list[str]]]:
|
||||
"""Run all configuration validations and log results"""
|
||||
from app.utils.config_validator.settings_display import dump_all_settings
|
||||
|
||||
|
||||
Reference in New Issue
Block a user