fix(similarity): address code review - column-only queries, configurable batch size, WCAG touch targets

- Use column-only query in embeddings overview to reduce memory for 100K+ files
- Add embedding_backfill_batch_size config setting (default 50)
- Fix WCAG touch target on backfill button (min-height/min-width 44px)
- Add inline comment explaining 3 chars/token truncation estimate
- Import settings in compute_embedding task for configurable batch size

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-03-02 13:39:10 +00:00
parent 8e955f3c81
commit 55543be3b0
5 changed files with 23 additions and 5 deletions
+11 -1
View File
@@ -257,7 +257,17 @@ def get_embeddings_overview(
}
```
"""
all_files = db.query(FileRecord).order_by(FileRecord.id.desc()).all()
# Use column-only query to avoid loading full ORM objects into memory
all_files = (
db.query(
FileRecord.id,
FileRecord.original_filename,
FileRecord.ocr_text,
FileRecord.embedding,
)
.order_by(FileRecord.id.desc())
.all()
)
files_info = []
total_with_ocr = 0