gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: fix static method warnings, hard-coded credentials, and Annotated type hints

Browse Source 
- Add @staticmethod to 9 test methods in test_external_integrations.py
  that don't use self (PYL-R0201)
- Extract hard-coded password literals to constants in 6 test files
  to resolve S2068 warnings (fixtures_integration, test_imap_tasks,
  test_upload_tasks, test_upload_webdav_comprehensive,
  test_upload_webdav_integration, test_views_coverage)
- Migrate Form() dependency injection to Annotated type hints in
  dropbox.py, google_drive.py, onedrive.py (Sonar fastapi convention)

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-11 17:03:54 +00:00
parent 3a40fe59f5
commit 5e82f7c03a
9 changed files with 549 additions and 526 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/fixtures_integration.py
+43 -44
View File
@@ -11,6 +11,7 @@ This module provides fixtures for spinning up real infrastructure components:
These tests exercise the full application stack end-to-end.
"""
import os
import time
import pytest
@@ -31,16 +32,16 @@ _TEST_CREDENTIAL = "testpass" # noqa: S105
def postgres_container() -> Generator:
"""
Start a real PostgreSQL database container for testing.
This replaces the in-memory SQLite used in unit tests.
"""
with PostgresContainer("postgres:15-alpine") as postgres:
# Wait for PostgreSQL to be ready
time.sleep(2)
# Set environment variable for the app to use
os.environ["DATABASE_URL"] = postgres.get_connection_url()
yield {
"container": postgres,
"url": postgres.get_connection_url(),
@@ -56,23 +57,23 @@ def postgres_container() -> Generator:
def redis_container() -> Generator:
"""
Start a real Redis container for Celery broker/backend.
This provides actual message queueing and task result storage.
"""
with RedisContainer("redis:7-alpine") as redis:
# Wait for Redis to be ready
time.sleep(2)
# Build Redis URL manually
host = redis.get_container_host_ip()
port = redis.get_exposed_port(6379)
redis_url = f"redis://{host}:{port}/0"
# Set environment variables for the app
os.environ["REDIS_URL"] = redis_url
os.environ["CELERY_BROKER_URL"] = redis_url
os.environ["CELERY_RESULT_BACKEND"] = redis_url
yield {
"container": redis,
"url": redis_url,
@@ -85,32 +86,30 @@ def redis_container() -> Generator:
def gotenberg_container() -> Generator:
"""
Start a real Gotenberg container for PDF conversion.
This provides actual document conversion capabilities.
"""
container = DockerContainer("gotenberg/gotenberg:8")
container.with_exposed_ports(3000)
container.with_command(
"gotenberg --chromium-disable-javascript=false --chromium-allow-list=file:///.*"
)
container.with_command("gotenberg --chromium-disable-javascript=false --chromium-allow-list=file:///.*")
container.start()
time.sleep(5) # Gotenberg takes a bit longer to start
host = container.get_container_host_ip()
port = container.get_exposed_port(3000)
gotenberg_url = f"http://{host}:{port}"
# Set environment variable
os.environ["GOTENBERG_URL"] = gotenberg_url
yield {
"container": container,
"url": gotenberg_url,
"host": host,
"port": port,
}
container.stop()
@@ -124,13 +123,13 @@ def webdav_container() -> Generator:
container.with_env("AUTH_TYPE", "Basic")
container.with_env("USERNAME", "testuser")
container.with_env("PASSWORD", _TEST_CREDENTIAL)
container.start()
time.sleep(2)
host = container.get_container_host_ip()
port = container.get_exposed_port(80)
yield {
"container": container,
"url": f"http://{host}:{port}",
@@ -139,7 +138,7 @@ def webdav_container() -> Generator:
"username": "testuser",
"password": _TEST_CREDENTIAL,
}
container.stop()
@@ -147,20 +146,20 @@ def webdav_container() -> Generator:
def sftp_container() -> Generator:
"""
Start a real SFTP server for upload testing.
Uses atmoz/sftp which provides a simple SSH/SFTP server.
"""
container = DockerContainer("atmoz/sftp:latest")
container.with_exposed_ports(22)
# Create user: username:password:uid:gid:directory
container.with_command(f"testuser:{_TEST_CREDENTIAL}:1001:1001:upload")
container.start()
time.sleep(3) # SFTP server needs time to initialize
host = container.get_container_host_ip()
port = container.get_exposed_port(22)
yield {
"container": container,
"host": host,
@@ -169,7 +168,7 @@ def sftp_container() -> Generator:
"password": _TEST_CREDENTIAL,
"folder": "/home/testuser/upload",
}
container.stop()
@@ -177,16 +176,16 @@ def sftp_container() -> Generator:
def minio_container() -> Generator:
"""
Start a real MinIO container (S3-compatible storage).
MinIO provides S3-compatible API for testing S3 uploads.
"""
with MinioContainer() as minio:
time.sleep(2)
# MinIO uses random credentials, get them
access_key = minio.access_key
secret_key = minio.secret_key
yield {
"container": minio,
"url": minio.get_config()["endpoint"],
@@ -200,7 +199,7 @@ def minio_container() -> Generator:
def ftp_container() -> Generator:
"""
Start a real FTP server for upload testing.
Uses stilliard/pure-ftpd which provides a simple FTP server.
"""
container = DockerContainer("stilliard/pure-ftpd:latest")
@@ -209,13 +208,13 @@ def ftp_container() -> Generator:
container.with_env("FTP_USER_NAME", "testuser")
container.with_env("FTP_USER_PASS", _TEST_CREDENTIAL)
container.with_env("FTP_USER_HOME", "/home/testuser")
container.start()
time.sleep(3)
host = container.get_container_host_ip()
port = container.get_exposed_port(21)
yield {
"container": container,
"host": host,
@@ -224,7 +223,7 @@ def ftp_container() -> Generator:
"password": _TEST_CREDENTIAL,
"folder": "/",
}
container.stop()
@@ -239,7 +238,7 @@ def full_infrastructure(
):
"""
Combined fixture that provides all infrastructure components.
Use this fixture when you need the complete application stack.
"""
return {
@@ -256,11 +255,11 @@ def full_infrastructure(
def celery_app(redis_container):
"""
Create a Celery app configured to use the real Redis container.
This allows testing actual task queueing and execution.
"""
from app.celery_app import celery
# Update Celery configuration to use test Redis
celery.conf.update(
broker_url=redis_container["url"],
@@ -269,7 +268,7 @@ def celery_app(redis_container):
task_eager_propagates=True,
result_expires=3600,
)
return celery
@@ -277,11 +276,11 @@ def celery_app(redis_container):
def celery_worker(celery_app, redis_container):
"""
Start a real Celery worker for processing tasks.
This runs tasks asynchronously like in production.
"""
from celery.contrib.testing.worker import start_worker
# Start worker in test mode
with start_worker(
celery_app,
@@ -296,23 +295,23 @@ def celery_worker(celery_app, redis_container):
def db_session_real(postgres_container):
"""
Create a database session using the real PostgreSQL container.
This replaces the in-memory SQLite session for integration tests.
"""
from sqlalchemy import create_engine
from sqlalchemy.orm import sessionmaker
from app.database import Base
# Create engine using PostgreSQL container
engine = create_engine(postgres_container["url"])
# Create all tables
Base.metadata.create_all(bind=engine)
# Create session
SessionLocal = sessionmaker(autocommit=False, autoflush=False, bind=engine)
session = SessionLocal()
try:
yield session
finally: