From 6e50c6197082bbf2de2935cca1b74602789383f4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 10 Mar 2026 00:37:24 +0000 Subject: [PATCH] test(tasks): add _should_upload_to_icloud mock to send_to_all tests Add icloud upload check mock alongside existing _should_upload_to_* function mocks in all TestSendToAllDestinations test methods. Changes: - Import _should_upload_to_icloud from app.tasks.send_to_all - Add @patch decorator for _should_upload_to_icloud in 9 test methods - Add mock_icloud parameter to each test method signature - Set mock_icloud.return_value = False where other mocks are set to False Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- tests/test_send_to_all.py | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/tests/test_send_to_all.py b/tests/test_send_to_all.py index d4632a6d..ac05c29c 100644 --- a/tests/test_send_to_all.py +++ b/tests/test_send_to_all.py @@ -204,12 +204,14 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all.upload_to_dropbox") def test_queues_single_configured_service( self, mock_upload, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -239,6 +241,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False mock_upload.delay.return_value = MagicMock(id="task-123") result = send_to_all_destinations.apply(args=[str(test_file), False, 1]) @@ -250,6 +253,7 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all.log_task_progress") @patch("app.tasks.send_to_all.settings") @patch("app.tasks.send_to_all._should_upload_to_dropbox") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_nextcloud") @patch("app.tasks.send_to_all._should_upload_to_paperless") @@ -274,6 +278,7 @@ class TestSendToAllDestinations: mock_paperless, mock_nextcloud, mock_should_s3, + mock_icloud, mock_should_dropbox, mock_settings, mock_log, @@ -316,10 +321,12 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") def test_skips_unconfigured_services( self, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -349,6 +356,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False result = send_to_all_destinations.apply(args=[str(test_file), False, 1]) @@ -369,12 +377,14 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all.upload_to_dropbox") def test_with_file_id_parameter( self, mock_upload, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -404,6 +414,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False mock_upload.delay.return_value = MagicMock(id="task-123") result = send_to_all_destinations.apply(args=[str(test_file), False, 42]) @@ -425,6 +436,7 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all.get_configured_services_from_validator") @patch("app.tasks.send_to_all.upload_to_dropbox") @@ -433,6 +445,7 @@ class TestSendToAllDestinations: mock_upload, mock_validator, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -463,6 +476,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False mock_upload.delay.return_value = MagicMock(id="task-123") result = send_to_all_destinations.apply(args=[str(test_file), True, 1]) @@ -482,12 +496,14 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all.get_configured_services_from_validator") def test_validator_exception_fallback( self, mock_validator, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -518,6 +534,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False # Should not raise, should fall back to individual checks result = send_to_all_destinations.apply(args=[str(test_file), True, 1]) @@ -536,12 +553,14 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all.upload_to_dropbox") def test_handles_upload_task_queue_error( self, mock_upload, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -571,6 +590,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False mock_upload.delay.side_effect = Exception("Queue error") # Should not raise, should log error @@ -580,6 +600,7 @@ class TestSendToAllDestinations: # Error should be recorded in results assert "dropbox_error" in result.result["tasks"] + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_email") @@ -608,6 +629,7 @@ class TestSendToAllDestinations: mock_email, mock_onedrive, mock_s3, + mock_icloud, tmp_path, ): """Test file_id lookup fallback when not provided.""" @@ -629,6 +651,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False # Mock database session mock_db = MagicMock() @@ -656,10 +679,12 @@ class TestSendToAllDestinations: @patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_onedrive") + @patch("app.tasks.send_to_all._should_upload_to_icloud") @patch("app.tasks.send_to_all._should_upload_to_s3") def test_should_upload_check_exception_handling( self, mock_s3, + mock_icloud, mock_onedrive, mock_email, mock_sftp, @@ -689,6 +714,7 @@ class TestSendToAllDestinations: mock_email.return_value = False mock_onedrive.return_value = False mock_s3.return_value = False + mock_icloud.return_value = False # Should not raise, should treat as not configured result = send_to_all_destinations.apply(args=[str(test_file), False, 1])