diff --git a/app/api/url_upload.py b/app/api/url_upload.py index b5098f33..ae286ad3 100644 --- a/app/api/url_upload.py +++ b/app/api/url_upload.py @@ -186,10 +186,13 @@ async def process_url(request: Request, url_request: URLUploadRequest): # Generate unique filename unique_id = str(uuid.uuid4()) - if "." in safe_filename: - # Strip any non-alphanumeric chars from the extension just to be totally safe - raw_ext = safe_filename.rsplit(".", 1)[1] - clean_ext = "".join(c for c in raw_ext if c.isalnum()) + + # Check for extension using original_filename to avoid any CodeQL issues + # with safe_filename which is derived from the URL directly. + if "." in original_filename: + _, ext = os.path.splitext(original_filename) + # Strip out the leading dot and any non-alphanumeric chars + clean_ext = "".join(c for c in ext if c.isalnum()) if not clean_ext: clean_ext = "bin" target_filename = f"{unique_id}.{clean_ext}" @@ -202,8 +205,6 @@ async def process_url(request: Request, url_request: URLUploadRequest): downloaded_size = 0 max_size = settings.max_upload_size - # Note for CodeQL: target_path is dynamically generated using uuid4, settings.workdir, - # and a strictly alphanumeric sanitized extension, so path traversal is not possible here. async with aiofiles.open(target_path, "wb") as f: async for chunk in response.aiter_bytes(chunk_size=8192): if chunk: