gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase HTTP request timeout to 120s for large file processing (up to 1GB PDFs)

Browse Source 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-07 19:39:57 +00:00
parent 755ef8a2e5
commit 7fc2703d90
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.env.demo
+2 -1
View File
@@ -138,7 +138,8 @@ SFTP_FOLDER=/Documents/Uploads
SFTP_DISABLE_HOST_KEY_VERIFICATION=True # Set to False in production for security SFTP_DISABLE_HOST_KEY_VERIFICATION=True # Set to False in production for security
# **HTTP Request Settings** # **HTTP Request Settings**
HTTP_REQUEST_TIMEOUT=30 # Timeout for HTTP requests in seconds (default: 30) # Timeout for HTTP requests - set higher to handle large PDF files (up to 1GB)
HTTP_REQUEST_TIMEOUT=120 # Timeout in seconds (default: 120 for large file operations)
# **Notification Settings** # **Notification Settings**
# Configure notification services using Apprise URL format # Configure notification services using Apprise URL format
SECURITY_AUDIT.md
+9 -2
View File
@@ -78,9 +78,16 @@ This document tracks security vulnerabilities found in DocuElevate and their rem
**Issue:** HTTP requests without timeout can hang indefinitely, leading to resource exhaustion and potential DoS. **Issue:** HTTP requests without timeout can hang indefinitely, leading to resource exhaustion and potential DoS.
**Remediation:** **Remediation:**
- Added `http_request_timeout` configuration setting (default: 30 seconds) - Added `http_request_timeout` configuration setting (default: 120 seconds)
- Timeout configured to handle large file operations (PDFs up to 1GB+)
- Applied `timeout=settings.http_request_timeout` to all `requests.get()`, `requests.post()`, and `requests.put()` calls - Applied `timeout=settings.http_request_timeout` to all `requests.get()`, `requests.post()`, and `requests.put()` calls
- Configurable via environment variable: `HTTP_REQUEST_TIMEOUT=30` - Configurable via environment variable: `HTTP_REQUEST_TIMEOUT=120`
**Note:** The 120-second default timeout is appropriate for:
- Large PDF file uploads and downloads (up to 1GB)
- PDF conversion operations via Gotenberg
- Cloud storage uploads (Dropbox, OneDrive, Google Drive, Nextcloud, WebDAV)
- Document processing and OCR operations
### Low Severity Issues (Informational) ### Low Severity Issues (Informational)
app/config.py
+1 -1
View File
@@ -138,7 +138,7 @@ class Settings(BaseSettings):
uptime_kuma_ping_interval: int = 5 # Default ping interval in minutes uptime_kuma_ping_interval: int = 5 # Default ping interval in minutes
# HTTP request settings # HTTP request settings
http_request_timeout: int = 30 # Default timeout for HTTP requests in seconds http_request_timeout: int = 120 # Default timeout for HTTP requests in seconds (handles large file operations)
# Feature flags # Feature flags
allow_file_delete: bool = True # Default to allowing file deletion from database allow_file_delete: bool = True # Default to allowing file deletion from database
app/tasks/upload_to_nextcloud.py
+1 -1
View File
@@ -120,7 +120,7 @@ def upload_to_nextcloud(self, file_path: str, file_id: int = None):
data=file_data, data=file_data,
auth=HTTPBasicAuth(settings.nextcloud_username, settings.nextcloud_password), auth=HTTPBasicAuth(settings.nextcloud_username, settings.nextcloud_password),
headers={'Content-Type': 'application/octet-stream'}, headers={'Content-Type': 'application/octet-stream'},
timeout=60 # Longer timeout for larger files timeout=settings.http_request_timeout # Use configured timeout for large files
) )
if response.status_code in (201, 204): # Created or No Content if response.status_code in (201, 204): # Created or No Content