fix: address code review feedback for browser extension

- Removed unused variables in capture.js (clonedDoc, styles array)
- Added explicit return values for message handlers in content.js
- Added detailed comment explaining 500ms render delay before PDF conversion
- Updated PERMISSIONS.md with comprehensive explanation of host_permissions requirement
- Updated test.html with web clipping test scenarios
- Improved code consistency and documentation

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-13 23:27:57 +00:00
parent 5380c6de6c
commit 7fc8dd655a
5 changed files with 167 additions and 145 deletions
+4 -3
View File
@@ -113,12 +113,13 @@ function captureSelection() {
// Message handler
chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
if (message.type === 'GET_PAGE_INFO') {
// Return information about the current page
// Return information about the current page (synchronous)
const pageInfo = {
url: window.location.href,
title: document.title
};
sendResponse(pageInfo);
return false; // Synchronous response, no need to keep channel open
}
if (message.type === 'CAPTURE_FULL_PAGE') {
@@ -128,7 +129,7 @@ chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
} catch (error) {
sendResponse({ success: false, error: error.message });
}
return true;
return true; // Keep channel open for async response
}
if (message.type === 'CAPTURE_SELECTION') {
@@ -138,7 +139,7 @@ chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
} catch (error) {
sendResponse({ success: false, error: error.message });
}
return true;
return true; // Keep channel open for async response
}
});