gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(onedrive): use async httpx for token refresh

Browse Source 
Replaces the synchronous `requests.post` and `requests.get` calls in
`app/api/onedrive.py:test_onedrive_token` with an asynchronous
`httpx.AsyncClient` implementation. This unblocks the FastAPI event loop
when this endpoint is hit.

Fixed unused requests import in `app/api/onedrive.py` and sorted imports in the testing files updated previously to adhere to the repository formatting (`ruff check --fix`). Tests in `test_api_onedrive_extended.py` were also migrated to use AsyncMock properly.

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
google-labs-jules[bot]
2026-03-16 09:53:14 +00:00
parent 2471921204
commit 827979598e
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_api_onedrive_extended.py
+12 -12
View File
@@ -1,7 +1,7 @@
"""Comprehensive unit tests for app/api/onedrive.py module.""" """Comprehensive unit tests for app/api/onedrive.py module."""
from datetime import timedelta from datetime import timedelta
from unittest.mock import MagicMock, patch from unittest.mock import AsyncMock, MagicMock, patch
import pytest import pytest
@@ -48,8 +48,8 @@ class TestExchangeOneDriveToken:
class TestTestOneDriveToken: class TestTestOneDriveToken:
"""Tests for GET /onedrive/test-token endpoint.""" """Tests for GET /onedrive/test-token endpoint."""
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
@patch("app.api.onedrive.requests.get") @patch("httpx.AsyncClient.get", new_callable=AsyncMock)
def test_test_token_success(self, mock_get, mock_post): def test_test_token_success(self, mock_get, mock_post):
"""Test successful token validation.""" """Test successful token validation."""
from app.config import settings from app.config import settings
@@ -79,7 +79,7 @@ class TestTestOneDriveToken:
# Should return success # Should return success
pass pass
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
def test_test_token_not_configured(self, mock_post): def test_test_token_not_configured(self, mock_post):
"""Test when credentials are not configured.""" """Test when credentials are not configured."""
from app.config import settings from app.config import settings
@@ -88,7 +88,7 @@ class TestTestOneDriveToken:
# Should return error # Should return error
pass pass
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
def test_test_token_refresh_failed(self, mock_post): def test_test_token_refresh_failed(self, mock_post):
"""Test when token refresh fails.""" """Test when token refresh fails."""
from app.config import settings from app.config import settings
@@ -104,8 +104,8 @@ class TestTestOneDriveToken:
# Should return error with needs_reauth # Should return error with needs_reauth
pass pass
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
@patch("app.api.onedrive.requests.get") @patch("httpx.AsyncClient.get", new_callable=AsyncMock)
def test_test_token_user_info_failed(self, mock_get, mock_post): def test_test_token_user_info_failed(self, mock_get, mock_post):
"""Test when user info request fails.""" """Test when user info request fails."""
from app.config import settings from app.config import settings
@@ -128,8 +128,8 @@ class TestTestOneDriveToken:
# Should return error # Should return error
pass pass
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
@patch("app.api.onedrive.requests.get") @patch("httpx.AsyncClient.get", new_callable=AsyncMock)
@patch("builtins.open", create=True) @patch("builtins.open", create=True)
@patch("os.path.exists") @patch("os.path.exists")
def test_test_token_updates_refresh_token(self, mock_exists, mock_open, mock_get, mock_post): def test_test_token_updates_refresh_token(self, mock_exists, mock_open, mock_get, mock_post):
@@ -167,8 +167,8 @@ class TestTestOneDriveToken:
# Should update refresh token in memory and file # Should update refresh token in memory and file
pass pass
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
@patch("app.api.onedrive.requests.get") @patch("httpx.AsyncClient.get", new_callable=AsyncMock)
def test_test_token_expiration_info(self, mock_get, mock_post): def test_test_token_expiration_info(self, mock_get, mock_post):
"""Test that expiration info is included.""" """Test that expiration info is included."""
from app.config import settings from app.config import settings
@@ -195,7 +195,7 @@ class TestTestOneDriveToken:
# token_info should include expiration details # token_info should include expiration details
pass pass
@patch("app.api.onedrive.requests.post") @patch("httpx.AsyncClient.post", new_callable=AsyncMock)
def test_test_token_exception_handling(self, mock_post): def test_test_token_exception_handling(self, mock_post):
"""Test handling of exceptions.""" """Test handling of exceptions."""
from app.config import settings from app.config import settings