gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(settings): rollback restores old_value instead of new_value and supports deletion fallback

Browse Source 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-23 12:15:44 +00:00
parent 8fd107a682
commit 862ba99802
4 changed files with 35 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/api/settings.py
+5 -4
View File
@@ -434,12 +434,13 @@ async def rollback_setting_to_history(
admin: AdminUser,
):
"""
Revert a setting to the value it held at a specific point in the audit log.
Revert a setting to the value it had *before* a specific audit log change.
The ``history_id`` is the ID of the :class:`~app.models.SettingsAuditLog`
entry whose ``new_value`` should be reinstated. If that entry recorded a
deletion (``new_value`` is ``None``), the setting is removed from the
database and reverts to its ENV/default value.
entry whose ``old_value`` should be reinstated, effectively undoing that
change. If ``old_value`` is ``None`` (the setting did not exist before
that change), the setting is removed from the database and reverts to its
ENV/default value.
A new audit log entry is written to record the rollback.
Admin only.