fix(auth): activate account on password reset and fix is_active check order

- reset_password sets is_active=True so users with unverified accounts
  can log in after using the forgot-password flow
- admin set_password also sets is_active=True for the same reason
- auth() now checks is_active before verifying the password, ensuring
  inactive users always see the email-verification prompt regardless of
  password correctness (avoids leaking password validity)"

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>

app/api/admin_users.py

@@ -488,9 +488,11 @@ def admin_set_password(
         raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Local user not found.")
 
     user.hashed_password = hash_password(body.password)
-    # Clear any outstanding reset tokens
+    # Clear any outstanding reset tokens and activate the account so the user
+    # can log in immediately after an admin sets their password.
     user.password_reset_token = None
     user.password_reset_sent_at = None
+    user.is_active = True
 
     try:
         db.commit()

app/api/local_auth.py

@@ -366,6 +366,9 @@ async def reset_password(body: PasswordResetBody, db: DbSession) -> dict[str, st
     user.hashed_password = hash_password(body.new_password)
     user.password_reset_token = None
     user.password_reset_sent_at = None
+    # Activate the account in case it was still pending email verification.
+    # A valid password-reset token proves control of the registered email address.
+    user.is_active = True
     db.commit()
 
     logger.info("[SECURITY] PASSWORD_RESET_SUCCESS user=%s", user.email)

app/auth.py

@@ -318,15 +318,15 @@ async def auth(request: Request, db: Session = Depends(get_db)):
             db.query(_LocalUser).filter((_LocalUser.username == username) | (_LocalUser.email == username)).first()
         )
         if local_user is not None:
-            if not _verify_password(password or "", local_user.hashed_password):
-                logger.warning("[SECURITY] LOCAL_LOGIN_FAILURE user=%s", username)
-                return RedirectResponse(url="/login?error=Invalid+username+or+password", status_code=302)
             if not local_user.is_active:
                 logger.warning("[SECURITY] LOCAL_LOGIN_UNVERIFIED user=%s", username)
                 return RedirectResponse(
                     url="/login?error=Please+verify+your+email+address+before+logging+in",
                     status_code=302,
                 )
+            if not _verify_password(password or "", local_user.hashed_password):
+                logger.warning("[SECURITY] LOCAL_LOGIN_FAILURE user=%s", username)
+                return RedirectResponse(url="/login?error=Invalid+username+or+password", status_code=302)
             user_data = _build_session_user(local_user)
             request.session["user"] = user_data
             logger.info("[SECURITY] LOCAL_LOGIN_SUCCESS user=%s", local_user.email)