fix: address code review feedback - use specific exceptions, dynamic revision IDs in tests

- Replace bare Exception catches with sa.exc.OperationalError in migration 007
- Use ScriptDirectory.get_heads() for dynamic revision ID assertions in tests
- Make migration count assertion flexible (>= 8 instead of == 8)
- Rewrite pending migrations test to actually test upgrade from revision 006

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>

migrations/versions/007_add_ocr_quality_drop_filehash_unique.py

@@ -29,11 +29,11 @@ def upgrade() -> None:
     # The filehash column retains a non-unique index for lookups.
     try:
         op.drop_index("ix_files_filehash", table_name="files")
-    except Exception as exc:
+    except sa.exc.OperationalError as exc:
         logger.debug("Could not drop ix_files_filehash (may not exist): %s", exc)
     try:
         op.create_index("ix_files_filehash", "files", ["filehash"], unique=False)
-    except Exception as exc:
+    except sa.exc.OperationalError as exc:
         logger.debug("Could not create ix_files_filehash (may already exist): %s", exc)
 
 

migrations/versions/008_add_performance_indexes.py

@@ -29,9 +29,7 @@ def upgrade() -> None:
     conn.execute(text("CREATE INDEX IF NOT EXISTS ix_files_mime_type ON files (mime_type)"))
     conn.execute(text("CREATE INDEX IF NOT EXISTS ix_processing_logs_file_id ON processing_logs (file_id)"))
     conn.execute(text("CREATE INDEX IF NOT EXISTS ix_processing_logs_timestamp ON processing_logs (timestamp)"))
-    conn.execute(
-        text("CREATE INDEX IF NOT EXISTS ix_file_processing_steps_status ON file_processing_steps (status)")
-    )
+    conn.execute(text("CREATE INDEX IF NOT EXISTS ix_file_processing_steps_status ON file_processing_steps (status)"))
 
 
 def downgrade() -> None: