gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: change SFTP host key verification default to secure (False)

Browse Source 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-10 15:39:23 +00:00
parent 04c44e6bad
commit 9a89f70cf4
4 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/config.py
+3 -3
View File
@@ -107,9 +107,9 @@ class Settings(BaseSettings):
sftp_folder: Optional[str] = None
sftp_private_key: Optional[str] = None
sftp_private_key_passphrase: Optional[str] = None
# Security: Disable host key verification only in development/testing environments
# In production, set to True and configure known_hosts file
sftp_disable_host_key_verification: bool = True # Default allows connection without known_hosts
# Security: Host key verification is enabled by default for security
# In development/testing, set to True to disable verification (not recommended)
sftp_disable_host_key_verification: bool = False # Default enforces host key verification
# Email settings
email_host: Optional[str] = None
app/tasks/upload_to_sftp.py
+5 -4
View File
@@ -48,12 +48,13 @@ def upload_to_sftp(self, file_path: str, file_id: int = None):
ssh = paramiko.SSHClient()
# Security: Host key verification
# WARNING: AutoAddPolicy automatically trusts unknown host keys (vulnerable to MITM attacks)
# For production, use RejectPolicy and configure known_hosts, or WarningPolicy at minimum
if getattr(settings, "sftp_disable_host_key_verification", True):
# By default (sftp_disable_host_key_verification=False), we use RejectPolicy for security
# Setting sftp_disable_host_key_verification=True disables verification (for testing only)
if getattr(settings, "sftp_disable_host_key_verification", False):
logger.warning(
"SFTP host key verification is DISABLED - connections are vulnerable to MITM attacks. "
"For production, set SFTP_DISABLE_HOST_KEY_VERIFICATION=false and configure known_hosts."
"This should only be used in development/testing. For production, remove "
"SFTP_DISABLE_HOST_KEY_VERIFICATION or set it to False and configure known_hosts."
)
ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy()) # nosec B507 - Configurable, warns user
else: