gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(tasks): add _should_upload_to_icloud mock to send_to_all tests

Browse Source 
Add icloud upload check mock alongside existing _should_upload_to_*
function mocks in all TestSendToAllDestinations test methods.

Changes:
- Import _should_upload_to_icloud from app.tasks.send_to_all
- Add @patch decorator for _should_upload_to_icloud in 9 test methods
- Add mock_icloud parameter to each test method signature
- Set mock_icloud.return_value = False where other mocks are set to False

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-03-10 00:37:24 +00:00
parent 9c71e9aabf
commit 9bc23aa40b
1 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_send_to_all.py
+26
View File
@@ -204,12 +204,14 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all.upload_to_dropbox") @patch("app.tasks.send_to_all.upload_to_dropbox")
def test_queues_single_configured_service( def test_queues_single_configured_service(
self, self,
mock_upload, mock_upload,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -239,6 +241,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
mock_upload.delay.return_value = MagicMock(id="task-123") mock_upload.delay.return_value = MagicMock(id="task-123")
result = send_to_all_destinations.apply(args=[str(test_file), False, 1]) result = send_to_all_destinations.apply(args=[str(test_file), False, 1])
@@ -250,6 +253,7 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all.log_task_progress") @patch("app.tasks.send_to_all.log_task_progress")
@patch("app.tasks.send_to_all.settings") @patch("app.tasks.send_to_all.settings")
@patch("app.tasks.send_to_all._should_upload_to_dropbox") @patch("app.tasks.send_to_all._should_upload_to_dropbox")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all._should_upload_to_nextcloud") @patch("app.tasks.send_to_all._should_upload_to_nextcloud")
@patch("app.tasks.send_to_all._should_upload_to_paperless") @patch("app.tasks.send_to_all._should_upload_to_paperless")
@@ -274,6 +278,7 @@ class TestSendToAllDestinations:
mock_paperless, mock_paperless,
mock_nextcloud, mock_nextcloud,
mock_should_s3, mock_should_s3,
mock_icloud,
mock_should_dropbox, mock_should_dropbox,
mock_settings, mock_settings,
mock_log, mock_log,
@@ -316,10 +321,12 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
def test_skips_unconfigured_services( def test_skips_unconfigured_services(
self, self,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -349,6 +356,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
result = send_to_all_destinations.apply(args=[str(test_file), False, 1]) result = send_to_all_destinations.apply(args=[str(test_file), False, 1])
@@ -369,12 +377,14 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all.upload_to_dropbox") @patch("app.tasks.send_to_all.upload_to_dropbox")
def test_with_file_id_parameter( def test_with_file_id_parameter(
self, self,
mock_upload, mock_upload,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -404,6 +414,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
mock_upload.delay.return_value = MagicMock(id="task-123") mock_upload.delay.return_value = MagicMock(id="task-123")
result = send_to_all_destinations.apply(args=[str(test_file), False, 42]) result = send_to_all_destinations.apply(args=[str(test_file), False, 42])
@@ -425,6 +436,7 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all.get_configured_services_from_validator") @patch("app.tasks.send_to_all.get_configured_services_from_validator")
@patch("app.tasks.send_to_all.upload_to_dropbox") @patch("app.tasks.send_to_all.upload_to_dropbox")
@@ -433,6 +445,7 @@ class TestSendToAllDestinations:
mock_upload, mock_upload,
mock_validator, mock_validator,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -463,6 +476,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
mock_upload.delay.return_value = MagicMock(id="task-123") mock_upload.delay.return_value = MagicMock(id="task-123")
result = send_to_all_destinations.apply(args=[str(test_file), True, 1]) result = send_to_all_destinations.apply(args=[str(test_file), True, 1])
@@ -482,12 +496,14 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all.get_configured_services_from_validator") @patch("app.tasks.send_to_all.get_configured_services_from_validator")
def test_validator_exception_fallback( def test_validator_exception_fallback(
self, self,
mock_validator, mock_validator,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -518,6 +534,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
# Should not raise, should fall back to individual checks # Should not raise, should fall back to individual checks
result = send_to_all_destinations.apply(args=[str(test_file), True, 1]) result = send_to_all_destinations.apply(args=[str(test_file), True, 1])
@@ -536,12 +553,14 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all.upload_to_dropbox") @patch("app.tasks.send_to_all.upload_to_dropbox")
def test_handles_upload_task_queue_error( def test_handles_upload_task_queue_error(
self, self,
mock_upload, mock_upload,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -571,6 +590,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
mock_upload.delay.side_effect = Exception("Queue error") mock_upload.delay.side_effect = Exception("Queue error")
# Should not raise, should log error # Should not raise, should log error
@@ -580,6 +600,7 @@ class TestSendToAllDestinations:
# Error should be recorded in results # Error should be recorded in results
assert "dropbox_error" in result.result["tasks"] assert "dropbox_error" in result.result["tasks"]
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@@ -608,6 +629,7 @@ class TestSendToAllDestinations:
mock_email, mock_email,
mock_onedrive, mock_onedrive,
mock_s3, mock_s3,
mock_icloud,
tmp_path, tmp_path,
): ):
"""Test file_id lookup fallback when not provided.""" """Test file_id lookup fallback when not provided."""
@@ -629,6 +651,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
# Mock database session # Mock database session
mock_db = MagicMock() mock_db = MagicMock()
@@ -656,10 +679,12 @@ class TestSendToAllDestinations:
@patch("app.tasks.send_to_all._should_upload_to_sftp") @patch("app.tasks.send_to_all._should_upload_to_sftp")
@patch("app.tasks.send_to_all._should_upload_to_email") @patch("app.tasks.send_to_all._should_upload_to_email")
@patch("app.tasks.send_to_all._should_upload_to_onedrive") @patch("app.tasks.send_to_all._should_upload_to_onedrive")
@patch("app.tasks.send_to_all._should_upload_to_icloud")
@patch("app.tasks.send_to_all._should_upload_to_s3") @patch("app.tasks.send_to_all._should_upload_to_s3")
def test_should_upload_check_exception_handling( def test_should_upload_check_exception_handling(
self, self,
mock_s3, mock_s3,
mock_icloud,
mock_onedrive, mock_onedrive,
mock_email, mock_email,
mock_sftp, mock_sftp,
@@ -689,6 +714,7 @@ class TestSendToAllDestinations:
mock_email.return_value = False mock_email.return_value = False
mock_onedrive.return_value = False mock_onedrive.return_value = False
mock_s3.return_value = False mock_s3.return_value = False
mock_icloud.return_value = False
# Should not raise, should treat as not configured # Should not raise, should treat as not configured
result = send_to_all_destinations.apply(args=[str(test_file), False, 1]) result = send_to_all_destinations.apply(args=[str(test_file), False, 1])