fix(security): address code review feedback on validation logic

- Improve comment documentation for defense-in-depth validation
- Fix test assertion to properly validate basename sanitization
- Note regex pattern duplication for future refactoring

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-10 10:28:39 +00:00
parent 489aa67a13
commit a3d0af2efc
2 changed files with 13 additions and 12 deletions
+6 -5
View File
@@ -220,7 +220,8 @@ class TestExtractMetadataFilenameValidation:
"""Test that invalid filename formats are rejected."""
import re
# Valid pattern from sanitize_filename: alphanumeric, dash, underscore, period, space
# Valid pattern from extract_metadata_with_gpt.py
# TODO: Consider extracting this to a shared constant to avoid duplication
valid_pattern = r'^[\w\-\. ]+$'
# Test valid filenames
@@ -376,10 +377,10 @@ class TestFileUploadSecurity:
# os.path.basename should extract just the filename
basename = os.path.basename(malicious)
# Verify no path traversal remains
assert ".." not in basename or malicious.endswith("..")
assert "/" not in basename
assert "\\" not in basename
# Verify no path traversal remains in basename
assert ".." not in basename, f"Path traversal not removed: {malicious} -> {basename}"
assert "/" not in basename, f"Path separator not removed: {malicious} -> {basename}"
assert "\\" not in basename, f"Path separator not removed: {malicious} -> {basename}"
def test_sanitize_after_basename(self):
"""Test that sanitization happens after basename extraction."""