From a5a8cd94c9af17f39a36993c0f419404c60055c3 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 21 Mar 2026 21:58:12 +0000
Subject: [PATCH] fix(ui): address code review feedback for
 comments/annotations UX

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
Agent-Logs-Url: https://github.com/christianlouis/DocuElevate/sessions/20bbea80-fdfd-42d2-b0c2-756ca25b240b
---
 frontend/static/js/annotations.js   | 2 +-
 frontend/static/js/comments.js      | 6 ++----
 frontend/templates/file_detail.html | 8 +++++---
 frontend/translations/en.json       | 3 ++-
 4 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/frontend/static/js/annotations.js b/frontend/static/js/annotations.js
index 985b4135..35d0ede2 100644
--- a/frontend/static/js/annotations.js
+++ b/frontend/static/js/annotations.js
@@ -275,7 +275,7 @@
     var cancelBtn = document.createElement('button');
     cancelBtn.type = 'button';
     cancelBtn.className = 'annotation-cancel-btn';
-    cancelBtn.textContent = 'Cancel';
+    cancelBtn.textContent = _i18n.cancel || 'Cancel';
     cancelBtn.addEventListener('click', function () {
       contentDiv.textContent = originalText;
     });
diff --git a/frontend/static/js/comments.js b/frontend/static/js/comments.js
index e0cf9259..a6add2e0 100644
--- a/frontend/static/js/comments.js
+++ b/frontend/static/js/comments.js
@@ -255,7 +255,7 @@
     fetch('/api/files/' + _fileId + '/comments/' + commentId + '/resolve', {
       method: 'PATCH',
       headers: { 'Content-Type': 'application/json' },
-      body: JSON.stringify({ resolve: resolve }),
+      body: JSON.stringify({ is_resolved: resolve }),
     })
       .then(function (r) {
         if (!r.ok) throw new Error('Failed');
@@ -357,12 +357,10 @@
     var cancelBtn = document.createElement('button');
     cancelBtn.type = 'button';
     cancelBtn.className = 'comment-cancel-btn';
-    cancelBtn.textContent = 'Cancel';
+    cancelBtn.textContent = _i18n.cancel || 'Cancel';
     cancelBtn.addEventListener('click', function () {
       bodyDiv.innerHTML = originalHTML;
     });
-
-    btns.appendChild(saveBtn);
     btns.appendChild(cancelBtn);
     form.appendChild(textarea);
     form.appendChild(btns);
diff --git a/frontend/templates/file_detail.html b/frontend/templates/file_detail.html
index 9bb08b4e..2c1242bc 100644
--- a/frontend/templates/file_detail.html
+++ b/frontend/templates/file_detail.html
@@ -2339,7 +2339,7 @@
                 <input type="number" id="annotation-page-input" min="1" value="1" aria-label="{{ _('annotations.page') }}">
               </div>
               <div class="form-group">
-                <label for="annotation-type-input">Type</label>
+                <label for="annotation-type-input">{{ _("annotations.type") }}</label>
                 <select id="annotation-type-input" aria-label="Annotation type">
                   <option value="note">{{ _("annotations.type_note") }}</option>
                   <option value="highlight">{{ _("annotations.type_highlight") }}</option>
@@ -2384,7 +2384,8 @@
             delete_confirm: {{ _("comments.delete_confirm") | tojson }},
             reply_placeholder: {{ _("comments.reply_placeholder") | tojson }},
             body_placeholder: {{ _("comments.body_placeholder") | tojson }},
-            mention_users: {{ _("comments.mention_users") | tojson }}
+            mention_users: {{ _("comments.mention_users") | tojson }},
+            cancel: {{ _("common.cancel") | tojson }}
           };
           var annotationsI18n = {
             empty: {{ _("annotations.empty") | tojson }},
@@ -2396,7 +2397,8 @@
             type_note: {{ _("annotations.type_note") | tojson }},
             type_highlight: {{ _("annotations.type_highlight") | tojson }},
             type_underline: {{ _("annotations.type_underline") | tojson }},
-            type_strikethrough: {{ _("annotations.type_strikethrough") | tojson }}
+            type_strikethrough: {{ _("annotations.type_strikethrough") | tojson }},
+            cancel: {{ _("common.cancel") | tojson }}
           };
           if (typeof initComments === 'function') {
             initComments(fileId, userId, commentsI18n);
diff --git a/frontend/translations/en.json b/frontend/translations/en.json
index 9f5b042d..1af7a7a0 100644
--- a/frontend/translations/en.json
+++ b/frontend/translations/en.json
@@ -1942,5 +1942,6 @@
   "upload.uploading": "Uploading...",
   "upload.url_description": "Enter a direct link to a file (PDF, Office documents, or images)",
   "upload.url_label": "File URL",
-  "upload.url_placeholder": "https://example.com/document.pdf"
+  "upload.url_placeholder": "https://example.com/document.pdf",
+  "annotations.type": "Type"
 }