Address code review feedback

- Replace LIKE queries with exact matches in fallback lookups
- Add comments clarifying fallback queries should not be needed
- Fix duplicate comment in embed_metadata_into_pdf
- Add missing file_id parameter to log_task_progress call

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-06 22:35:30 +00:00
parent 74680c8849
commit adb0b2329e
3 changed files with 13 additions and 10 deletions
+5 -3
View File
@@ -26,12 +26,14 @@ def finalize_document_storage(self, original_file: str, processed_file: str, met
logger.info(f"[{task_id}] Finalizing document storage for {processed_file}")
log_task_progress(task_id, "finalize_document_storage", "in_progress", f"Finalizing: {os.path.basename(processed_file)}", file_id=file_id)
# Get file_id from database if not provided
# Get file_id from database if not provided (fallback only, prefer passing file_id explicitly)
if file_id is None:
with SessionLocal() as db:
# Try to find by the original file path
# Only as a last resort, try to find by exact match on local_filename
# This should not be needed if file_id is passed correctly through the chain
tmp_path = os.path.join(settings.workdir, "tmp", os.path.basename(original_file))
file_record = db.query(FileRecord).filter(
FileRecord.local_filename.like(f"%{os.path.basename(original_file)}%")
FileRecord.local_filename == tmp_path
).first()
if file_record:
file_id = file_record.id