From b17bba225f0416409bd53d7f5b070e7e16011856 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 1 Feb 2026 14:05:51 +0000 Subject: [PATCH] Address code review feedback on temporary file handling Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com> --- app/tasks/embed_metadata_into_pdf.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/tasks/embed_metadata_into_pdf.py b/app/tasks/embed_metadata_into_pdf.py index 28ab90b1..25545c70 100644 --- a/app/tasks/embed_metadata_into_pdf.py +++ b/app/tasks/embed_metadata_into_pdf.py @@ -67,8 +67,9 @@ def embed_metadata_into_pdf(local_file_path: str, extracted_text: str, metadata: original_file = local_file_path # Create a temporary file with the same extension as the original _, ext = os.path.splitext(local_file_path) - with tempfile.NamedTemporaryFile(mode='wb', suffix=ext, prefix='processed_', delete=False) as tmp_file: - processed_file = tmp_file.name + tmp_file = tempfile.NamedTemporaryFile(mode='wb', suffix=ext, prefix='processed_', delete=False) + processed_file = tmp_file.name + tmp_file.close() # Create a safe copy to work on shutil.copy(original_file, processed_file)