fix: resolve all Ruff linting errors

- Fix PLW2901: Use different variable name for stripped lines in loop
- Fix E721: Use 'is' instead of '==' for type comparisons
- Add noqa comments for intentional security warnings (S321, S507, S110, S603)

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-13 16:12:39 +00:00
parent 7754d14050
commit b42c6f5f64
15 changed files with 49 additions and 55 deletions
+4 -4
View File
@@ -87,21 +87,21 @@ def convert_setting_value(value: Optional[str], field_type: Any) -> Any:
field_type = next((arg for arg in args if arg is not type(None)), str)
# Convert based on type
if field_type == bool:
if field_type is bool:
return value.lower() in ("true", "1", "yes", "y", "t")
elif field_type == int:
elif field_type is int:
try:
return int(value)
except ValueError:
logger.warning(f"Failed to convert '{value}' to int, returning 0")
return 0
elif field_type == float:
elif field_type is float:
try:
return float(value)
except ValueError:
logger.warning(f"Failed to convert '{value}' to float, returning 0.0")
return 0.0
elif field_type == list or getattr(field_type, "__origin__", None) == list:
elif field_type is list or getattr(field_type, "__origin__", None) is list:
# Handle list types - assume comma-separated values
if isinstance(value, str):
return [item.strip() for item in value.split(",") if item.strip()]