fix: resolve all Ruff linting errors
- Fix PLW2901: Use different variable name for stripped lines in loop - Fix E721: Use 'is' instead of '==' for type comparisons - Add noqa comments for intentional security warnings (S321, S507, S110, S603) Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
@@ -207,9 +207,10 @@ class TestSecurityHeadersMiddleware:
|
||||
@pytest.mark.asyncio
|
||||
async def test_dispatch_adds_headers_when_enabled(self):
|
||||
"""Test dispatch adds security headers when enabled."""
|
||||
from fastapi import Response
|
||||
|
||||
from app.config import settings
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
if not settings.security_headers_enabled:
|
||||
pytest.skip("Security headers disabled in configuration")
|
||||
@@ -231,10 +232,10 @@ class TestSecurityHeadersMiddleware:
|
||||
@pytest.mark.asyncio
|
||||
async def test_dispatch_skips_headers_when_disabled(self):
|
||||
"""Test dispatch skips headers when disabled."""
|
||||
from app.config import settings
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
|
||||
# Create a config copy with headers disabled
|
||||
mock_config = Mock()
|
||||
mock_config.security_headers_enabled = False
|
||||
@@ -254,9 +255,10 @@ class TestSecurityHeadersMiddleware:
|
||||
|
||||
def test_add_security_headers_hsts(self):
|
||||
"""Test _add_security_headers adds HSTS header."""
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
|
||||
mock_config = Mock()
|
||||
mock_config.security_headers_enabled = True
|
||||
mock_config.security_header_hsts_enabled = True
|
||||
@@ -275,9 +277,10 @@ class TestSecurityHeadersMiddleware:
|
||||
|
||||
def test_add_security_headers_csp(self):
|
||||
"""Test _add_security_headers adds CSP header."""
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
|
||||
mock_config = Mock()
|
||||
mock_config.security_headers_enabled = True
|
||||
mock_config.security_header_hsts_enabled = False
|
||||
@@ -296,9 +299,10 @@ class TestSecurityHeadersMiddleware:
|
||||
|
||||
def test_add_security_headers_x_frame_options(self):
|
||||
"""Test _add_security_headers adds X-Frame-Options header."""
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
|
||||
mock_config = Mock()
|
||||
mock_config.security_headers_enabled = True
|
||||
mock_config.security_header_hsts_enabled = False
|
||||
@@ -317,9 +321,10 @@ class TestSecurityHeadersMiddleware:
|
||||
|
||||
def test_add_security_headers_x_content_type_options(self):
|
||||
"""Test _add_security_headers adds X-Content-Type-Options header."""
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
|
||||
mock_config = Mock()
|
||||
mock_config.security_headers_enabled = True
|
||||
mock_config.security_header_hsts_enabled = False
|
||||
@@ -337,9 +342,10 @@ class TestSecurityHeadersMiddleware:
|
||||
|
||||
def test_add_all_security_headers(self):
|
||||
"""Test _add_security_headers adds all headers when all enabled."""
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
from fastapi import Response
|
||||
|
||||
from app.middleware.security_headers import SecurityHeadersMiddleware
|
||||
|
||||
mock_config = Mock()
|
||||
mock_config.security_headers_enabled = True
|
||||
mock_config.security_header_hsts_enabled = True
|
||||
|
||||
Reference in New Issue
Block a user