fix(tests): use targeted settings mock instead of broad getattr patch

Replace module-level getattr patch with a MagicMock that has a property
raising on google_drive_use_oauth access, as suggested by code review.

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-26 09:16:49 +00:00
parent 096aedb8a0
commit c6ac6b50e9
+5 -1
View File
@@ -118,7 +118,11 @@ class TestGetTokenInfoOuterException:
def test_get_token_info_outer_exception(self, client: TestClient): def test_get_token_info_outer_exception(self, client: TestClient):
"""Trigger the outer exception handler in get_google_drive_token_info.""" """Trigger the outer exception handler in get_google_drive_token_info."""
with patch("app.api.google_drive.getattr", side_effect=Exception("boom")): mock_settings = MagicMock()
# Property on the mock type so getattr() propagates a non-AttributeError,
# bypassing the default value and reaching the outer except block.
type(mock_settings).google_drive_use_oauth = property(lambda self: (_ for _ in ()).throw(Exception("boom")))
with patch("app.api.google_drive.settings", mock_settings):
response = client.get("/api/google-drive/get-token-info") response = client.get("/api/google-drive/get-token-info")
assert response.status_code == 200 assert response.status_code == 200