From f4b793e9b8eae37f5917ed8a057e90ad0a36ade2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 6 Mar 2026 10:00:33 +0000 Subject: [PATCH] fix(tests): add missing mock settings attrs in test_original_filename_preservation The test was patching `settings` with a MagicMock but only setting `workdir`. Other attributes (`default_owner_id`, `enable_deduplication`, `show_deduplication_step`, `enable_text_quality_check`) remained as MagicMock objects. When `default_owner_id` (truthy MagicMock) was assigned to `owner_id` and passed to SQLAlchemy, SQLite rejected the unsupported type. Fix: explicitly set all accessed settings attributes to sensible test defaults in both test functions. Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com> --- tests/test_original_filename_preservation.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/test_original_filename_preservation.py b/tests/test_original_filename_preservation.py index 09efeab1..917ce702 100644 --- a/tests/test_original_filename_preservation.py +++ b/tests/test_original_filename_preservation.py @@ -95,6 +95,10 @@ startxref ): # Setup mocks mock_settings.workdir = str(tmp_path) + mock_settings.default_owner_id = "" + mock_settings.enable_deduplication = False + mock_settings.show_deduplication_step = False + mock_settings.enable_text_quality_check = False mock_session_local.return_value.__enter__.return_value = db_session mock_session_local.return_value.__exit__.return_value = None mock_extract.delay = MagicMock() @@ -195,6 +199,10 @@ startxref ): # Setup mocks mock_settings.workdir = str(tmp_path) + mock_settings.default_owner_id = "" + mock_settings.enable_deduplication = False + mock_settings.show_deduplication_step = False + mock_settings.enable_text_quality_check = False mock_session_local.return_value.__enter__.return_value = db_session mock_session_local.return_value.__exit__.return_value = None mock_extract.delay = MagicMock()