Merge pull request #815 from christianlouis/chore/refactor-save-settings-3579323758629064412

🧹 refactor: simplify save settings endpoints and fix naming

tests/test_api_google_drive_comprehensive.py

@@ -360,6 +360,15 @@ class TestFormatTimeRemaining:
 class TestSaveGoogleDriveSettings:
     """Tests for POST /google-drive/save-settings endpoint."""
 
+    @pytest.fixture(autouse=True)
+    def _admin_override(self):
+        from app.api.google_drive import _require_admin
+        from app.main import app as fastapi_app
+
+        fastapi_app.dependency_overrides[_require_admin] = lambda: {"is_admin": True}
+        yield
+        fastapi_app.dependency_overrides.pop(_require_admin, None)
+
     @patch("builtins.open", new_callable=mock_open, read_data="# Existing config\n")
     @patch("os.path.exists")
     @patch("os.path.dirname")

tests/test_api_google_drive_coverage.py

@@ -195,6 +195,15 @@ class TestGetGoogleDriveTokenInfo:
 class TestSaveGoogleDriveSettings:
     """Test save_google_drive_settings endpoint edge cases."""
 
+    @pytest.fixture(autouse=True)
+    def _admin_override(self):
+        from app.api.google_drive import _require_admin
+        from app.main import app as fastapi_app
+
+        fastapi_app.dependency_overrides[_require_admin] = lambda: {"is_admin": True}
+        yield
+        fastapi_app.dependency_overrides.pop(_require_admin, None)
+
     @patch("app.api.google_drive.settings")
     @patch("os.path.exists")
     def test_save_settings_env_file_not_exists(self, mock_exists, mock_settings, client: TestClient):

tests/test_api_google_drive_final.py

@@ -152,11 +152,16 @@ class TestGetTokenInfoCredentialsBranches:
 
 @pytest.mark.unit
 class TestSaveGoogleDriveSettingsFalsyFields:
-    """Cover branches 395->397, 449->451, 468->470 in save_google_drive_settings.
+    """Cover branches 395->397, 449->451, 468->470 in save_google_drive_settings."""
 
-    Note: the Google Drive save endpoint is named save_google_drive_settings in the
-    source (app/api/google_drive.py).
-    """
+    @pytest.fixture(autouse=True)
+    def _admin_override(self):
+        from app.api.google_drive import _require_admin
+        from app.main import app as fastapi_app
+
+        fastapi_app.dependency_overrides[_require_admin] = lambda: {"is_admin": True}
+        yield
+        fastapi_app.dependency_overrides.pop(_require_admin, None)
 
     @patch("app.api.google_drive.settings")
     @patch("os.path.exists", return_value=False)
@@ -177,6 +182,7 @@ class TestSaveGoogleDriveSettingsFalsyFields:
             with patch("app.api.google_drive.notify_settings_updated"):
                 result = await save_google_drive_settings(
                     request=mock_request,
+                    _admin={"is_admin": True},
                     refresh_token="",  # falsy → branches 395->397 and 449->451
                     client_id="cid",
                     client_secret=None,

tests/test_wizard_db_persist.py

@@ -129,6 +129,15 @@ class TestSetupWizardUndoSkip:
 class TestDropboxSaveSettingsDbPersist:
     """Unit tests for save_dropbox_settings DB persistence."""
 
+    @pytest.fixture(autouse=True)
+    def _admin_override(self):
+        from app.api.dropbox import _require_admin
+        from app.main import app as fastapi_app
+
+        fastapi_app.dependency_overrides[_require_admin] = lambda: {"is_admin": True}
+        yield
+        fastapi_app.dependency_overrides.pop(_require_admin, None)
+
     @patch("app.api.dropbox.settings")
     @patch("app.api.dropbox.notify_settings_updated")
     @patch("app.api.dropbox.save_setting_to_db")
@@ -268,6 +277,15 @@ class TestGoogleDriveUpdateSettingsDbPersist:
 class TestOneDriveSaveSettingsDbPersist:
     """Unit tests for save_onedrive_settings DB persistence."""
 
+    @pytest.fixture(autouse=True)
+    def _admin_override(self):
+        from app.api.onedrive import _require_admin
+        from app.main import app as fastapi_app
+
+        fastapi_app.dependency_overrides[_require_admin] = lambda: {"is_admin": True}
+        yield
+        fastapi_app.dependency_overrides.pop(_require_admin, None)
+
     @patch("app.api.onedrive.settings")
     @patch("app.api.onedrive.notify_settings_updated")
     @patch("app.api.onedrive.save_setting_to_db")