gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,070 Commits 28 Branches 0 Tags
6f510d5a2df2d701dd1ae317548c734a2d72fbe4
Commit Graph

9 Commits

Author SHA1 Message Date
google-labs-jules[bot] 6f510d5a2d refactor(tasks): extract filename regex to shared constant 
Move the valid filename regex pattern to a shared constant in `app/utils/filename_utils.py` and update both the task logic and security tests to use it. This eliminates duplication and ensures consistency across the codebase.

Changes:
- Defined `VALID_FILENAME_PATTERN` and `VALID_FILENAME_RE` in `app/utils/filename_utils.py`.
- Updated `app/tasks/extract_metadata_with_gpt.py` to use `VALID_FILENAME_RE`.
- Updated `tests/test_path_traversal_security.py` to use `VALID_FILENAME_PATTERN`.

This refactoring addresses the duplication mentioned in the TODO in `tests/test_path_traversal_security.py`.

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-03-23 18:58:29 +00:00
copilot-swe-agent[bot] 43bc58770d refactor: consolidate linting tools into Ruff 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-13 09:10:52 +00:00
Christian Krakau-Louis 3710aca6ce Merge pull request #260 from christianlouis/copilot/format-code-with-linters 
style: fix black, isort, and flake8 violations across app/ and tests/
 2026-02-12 04:24:04 +01:00
copilot-swe-agent[bot] ff9a3ff49f style: fix code formatting with black, isort, and flake8 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-12 03:21:41 +00:00
copilot-swe-agent[bot] 07c240df99 fix(test): update PyPDF2 patch references to pypdf in path traversal security test 
Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-12 03:19:32 +00:00
copilot-swe-agent[bot] ad39ee7afa fix(test): update 11 failing tests to match refactored status tracking and API changes 
- Update test_bulk_operations.py: Use FileProcessingStep instead of ProcessingLog for status filter tests
- Update test_file_listing.py: Use FileProcessingStep for processing status determination tests
- Update test_file_detail_endpoints.py: Replace hash_file with check_text in step summary test
- Update test_path_traversal_security.py: Import get_unique_filepath_with_counter from correct module
- Update test_process_document.py: Match current duplicate handling behavior (creates new record)

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-12 02:54:46 +00:00
copilot-swe-agent[bot] 7ad2bdfc4b fix(test): fix 5 pre-existing test failures in rate limiting, path traversal, and e2e tests 
- test_rate_limiting: remove references to non-existent rate_limit_process setting
- test_path_traversal_security: fix sanitize_filename assertion to match actual
  strip behavior, fix os.path.basename test for Linux (backslash not a separator),
  remove erroneous task_mock arg from embed_metadata_into_pdf direct call
- test_e2e_full_stack: add psycopg2 availability check to skip Postgres test
  when driver is not installed

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-11 15:31:46 +00:00
copilot-swe-agent[bot] a3d0af2efc fix(security): address code review feedback on validation logic 
- Improve comment documentation for defense-in-depth validation
- Fix test assertion to properly validate basename sanitization
- Note regex pattern duplication for future refactoring

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-10 10:28:39 +00:00
copilot-swe-agent[bot] 489aa67a13 fix(security): remediate path traversal vulnerabilities in file operations 
- Fix critical vulnerability: sanitize GPT metadata filename before use
- Fix insecure string-based path validation with pathlib methods
- Add validation for GPT-extracted filenames
- Add comprehensive security test suite (24 tests)
- Document all findings in SECURITY_AUDIT.md

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
 2026-02-10 10:26:42 +00:00