google-labs-jules[bot]
fe20e02f78
- Added a benchmark script in tests/test_notifications_api.py that proved the N+1 issue issue. - Replaced iterative DB lookups inside `for item in body.preferences:` with single pre-fetch query and local `prefs_dict` lookups. - Verified test benchmark time drops from ~0.0964s to ~0.0141s for a batch of 100 items. Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
51 lines
1.4 KiB
Python
51 lines
1.4 KiB
Python
import json
|
|
import time
|
|
import pytest
|
|
from app.database import get_db
|
|
from app.models import UserNotificationTarget, UserNotificationPreference
|
|
from app.main import app
|
|
from tests.test_notifications_api import _make_client, _OWNER, _cleanup
|
|
import statistics
|
|
|
|
def run_benchmark(notif_engine, notif_session, client, items_count, iterations=5):
|
|
# Setup
|
|
target = UserNotificationTarget(
|
|
owner_id=_OWNER,
|
|
channel_type="webhook",
|
|
name="My Webhook",
|
|
config=json.dumps({"url": "https://x.com"}),
|
|
)
|
|
notif_session.add(target)
|
|
notif_session.commit()
|
|
notif_session.refresh(target)
|
|
|
|
# Generate big payload
|
|
preferences = []
|
|
for i in range(items_count):
|
|
preferences.append({
|
|
"event_type": f"event.type.{i}",
|
|
"channel_type": "webhook",
|
|
"is_enabled": True,
|
|
"target_id": target.id,
|
|
})
|
|
|
|
payload = {"preferences": preferences}
|
|
|
|
# Warm up
|
|
client.put("/api/user-notifications/preferences", json=payload)
|
|
|
|
times = []
|
|
for _ in range(iterations):
|
|
# Alter the values a bit so it's a real update
|
|
for p in payload["preferences"]:
|
|
p["is_enabled"] = not p["is_enabled"]
|
|
|
|
start = time.time()
|
|
resp = client.put("/api/user-notifications/preferences", json=payload)
|
|
end = time.time()
|
|
|
|
assert resp.status_code == 200
|
|
times.append(end - start)
|
|
|
|
return statistics.mean(times)
|