google-labs-jules[bot]
d22175310a
🚨 Severity: HIGH 💡 Vulnerability: User-provided IMAP `host` in `_test_imap_connection` and `pull_inbox` was not validated against private IPs, creating an SSRF risk. 🎯 Impact: Attackers could abuse the endpoints to port-scan or interact with internal/private network services. 🔧 Fix: Integrated `is_private_ip` from `app.utils.network` to block connections resolving to private, loopback, link-local, or reserved IPs. ✅ Verification: Ran `test_imap_tasks.py` and `test_api_imap_accounts.py` successfully. Checked `ruff` output and diffs. Removed all scratch files from the commit. Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
29 lines
928 B
Python
29 lines
928 B
Python
"""Public view for accessing a shared document link.
|
|
|
|
This route does NOT require authentication — it is the landing page
|
|
that link recipients visit. The page fetches link metadata via the
|
|
public ``/api/share/{token}/info`` JSON endpoint and then renders the
|
|
appropriate download UI (password gate or direct download button).
|
|
"""
|
|
|
|
import logging
|
|
import pathlib
|
|
|
|
from fastapi import APIRouter, Request
|
|
from fastapi.templating import Jinja2Templates
|
|
|
|
logger = logging.getLogger(__name__)
|
|
router = APIRouter()
|
|
|
|
_templates_dir = pathlib.Path(__file__).parents[2] / "frontend" / "templates"
|
|
templates = Jinja2Templates(directory=str(_templates_dir))
|
|
|
|
|
|
@router.get("/share/{token}")
|
|
async def shared_link_view(request: Request, token: str):
|
|
"""Render the public share landing page for a given token."""
|
|
return templates.TemplateResponse(
|
|
"shared_link_view.html",
|
|
{"request": request, "token": token},
|
|
)
|