google-labs-jules[bot]
d71945b7b9
🚨 Severity: HIGH 💡 Vulnerability: User-provided IMAP `host` in `_test_imap_connection` and `pull_inbox` was not validated against private IPs, creating an SSRF risk. 🎯 Impact: Attackers could abuse the endpoints to port-scan or interact with internal/private network services. 🔧 Fix: Integrated `is_private_ip` from `app.utils.network` to block connections resolving to private, loopback, link-local, or reserved IPs. ✅ Verification: Ran `test_imap_tasks.py` and `test_api_imap_accounts.py` successfully. Checked `ruff` output and diffs. Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
11 lines
356 B
Python
11 lines
356 B
Python
import re
|
|
|
|
with open("app/api/imap_accounts.py", "r") as f:
|
|
content = f.read()
|
|
|
|
# Remove duplicate imports
|
|
content = re.sub(r"from app\.utils\.network import is_private_ip\nfrom app\.utils\.network import is_private_ip\n", "from app.utils.network import is_private_ip\n", content)
|
|
|
|
with open("app/api/imap_accounts.py", "w") as f:
|
|
f.write(content)
|