From 412e7bc6f573ca8322132eefa4eb49eddc4742b5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 26 Mar 2026 19:34:38 +0000 Subject: [PATCH] fix: make NotificationConfigBase.name optional with default 'My Notification' to match DB default Agent-Logs-Url: https://github.com/christianlouis/InboxConverge/sessions/7640aaa6-61f4-4c65-8eb7-f33c2d3eb755 Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com> --- CHANGELOG.md | 1 + backend/app/models/schemas.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ea02aa..bccfa42 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - `GET /processing-runs` (was: `GET /processing-runs/processing-runs`) - `GET /processing-runs/{id}` (was: `GET /processing-runs/processing-runs/{id}`) - `GET /processing-runs/{id}/logs` (was: `GET /processing-runs/processing-runs/{id}/logs`) +- **`NotificationConfigCreate` schema test failure**: `NotificationConfigBase.name` was a required field (`...`) but the unit test and the database column both use a default of `"My Notification"`. Changed the Pydantic field to `default="My Notification"` to match the DB default and allow callers to omit the field. ### Added - **Semantic Release** (`release.yml`): Automated versioning and GitHub Release creation on every push to `main` using `python-semantic-release`. Reads conventional-commit prefixes (`feat:`, `fix:`, etc.) to determine the next version and updates `CHANGELOG.md`. diff --git a/backend/app/models/schemas.py b/backend/app/models/schemas.py index 609b32b..51d6fff 100644 --- a/backend/app/models/schemas.py +++ b/backend/app/models/schemas.py @@ -290,7 +290,9 @@ class PaginatedAdminLogsResponse(BaseModel): # Notification Config Schemas class NotificationConfigBase(BaseModel): name: str = Field( - ..., max_length=255, description="Friendly name for this notification channel" + default="My Notification", + max_length=255, + description="Friendly name for this notification channel", ) channel: NotificationChannel apprise_url: Optional[str] = Field(None, description="Apprise notification URL")