refactor: address code-review comments (DNS constant, last_exc, comment clarity)

Agent-Logs-Url: https://github.com/christianlouis/InboxConverge/sessions/5ad49738-4b0b-4ed7-8686-07adb0ba9e5d Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
2026-05-03 22:09:08 +00:00
parent 92f60c6052
commit 428850b476
2 changed files with 10 additions and 4 deletions
@@ -538,8 +538,11 @@ async def process_mail_account(account_id: int):
            # Per-email failures are already tracked in ProcessingLog and the
            # run's emails_failed counter so the user can drill into them without
            # having the account badge stuck in ERROR indefinitely.
+            # Capture pre-mutation state for the post-commit notification logic.
+            # These must be read before the account status and flag are cleared below.
            _was_in_error = account.status == AccountStatus.ERROR  # type: ignore[comparison-overlap]
            _had_notified = bool(account.error_notification_sent)  # type: ignore[attr-defined]
+
            account.last_successful_check_at = datetime.now(timezone.utc)  # type: ignore[assignment]
            account.status = AccountStatus.ACTIVE  # type: ignore[assignment]
            account.last_error_message = None  # type: ignore[assignment]