fix: address multiple code quality improvements across backend and frontend

Backend fixes:
- Fix JWT sub claim: encode as str(user.id), decode with int() cast (python-jose requirement)
- Replace all deprecated datetime.utcnow() with datetime.now(timezone.utc)
- Replace deprecated FastAPI @app.on_event() with modern lifespan context manager
- Replace deprecated Pydantic class Config with model_config = ConfigDict(...)
- Replace deprecated Pydantic .dict() with .model_dump()
- Fix overly broad except (GmailInjectionError, Exception) → except Exception
- Remove unused GmailInjectionError import
- Fix TokenPayload schema sub field type from int to str

Frontend:
- Create frontend/src/lib/api.ts — API client module with auth, user, mail accounts, processing runs APIs
- Add !frontend/src/lib/ to .gitignore negation

Tests:
- Add 3 new JWT tests (sub string encoding, access token type, refresh token type)
- Update test_token_payload_schema for string sub claim
- All 128 tests pass

Co-authored-by: christianlouis <361235+christianlouis@users.noreply.github.com>
Agent-Logs-Url: https://github.com/christianlouis/pop_puller_to_gmail/sessions/e0b13eb0-8de7-4f02-81e4-e202cbba4608
This commit is contained in:
copilot-swe-agent[bot]
2026-03-23 13:09:23 +00:00
parent a513ef3c20
commit f439f887d0
15 changed files with 360 additions and 76 deletions
+11 -20
View File
@@ -4,7 +4,7 @@ Pydantic schemas for API request/response validation.
from datetime import datetime
from typing import Optional, Dict, Any, List
from pydantic import BaseModel, EmailStr, Field
from pydantic import BaseModel, ConfigDict, EmailStr, Field
from enum import Enum
@@ -65,8 +65,7 @@ class UserResponse(UserBase):
subscription_status: str
created_at: datetime
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
class UserDetailResponse(UserResponse):
@@ -76,8 +75,7 @@ class UserDetailResponse(UserResponse):
subscription_expires_at: Optional[datetime] = None
last_login_at: Optional[datetime] = None
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
# Authentication Schemas
@@ -88,7 +86,7 @@ class Token(BaseModel):
class TokenPayload(BaseModel):
sub: Optional[int] = None
sub: Optional[str] = None
exp: Optional[int] = None
type: Optional[str] = None
@@ -151,8 +149,7 @@ class MailAccountResponse(MailAccountBase):
password: str = Field(exclude=True, default="")
username: str = Field(exclude=True, default="")
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
class MailAccountTestRequest(BaseModel):
@@ -197,8 +194,7 @@ class ProcessingRunResponse(BaseModel):
status: str
error_message: Optional[str] = None
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
# Processing Log Schemas
@@ -211,8 +207,7 @@ class ProcessingLogResponse(BaseModel):
email_from: Optional[str] = None
success: bool
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
# Notification Config Schemas
@@ -243,8 +238,7 @@ class NotificationConfigResponse(NotificationConfigBase):
created_at: datetime
updated_at: datetime
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
# Subscription Schemas
@@ -262,8 +256,7 @@ class SubscriptionPlanResponse(BaseModel):
features: Optional[Dict[str, Any]] = None
is_active: bool
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
class SubscriptionCheckoutRequest(BaseModel):
@@ -311,8 +304,7 @@ class MailServerPresetResponse(BaseModel):
configs: Dict[str, Any]
is_verified: bool
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
# Gmail Credential Schemas
@@ -331,8 +323,7 @@ class GmailCredentialResponse(BaseModel):
created_at: datetime
updated_at: datetime
class Config:
from_attributes = True
model_config = ConfigDict(from_attributes=True)
# Provider Wizard Schemas