Merge pull request #61 from christianlouis/copilot/debug-mail-sources-500-error

fix: GET /mail-sources 500 — unhashable type: 'dict' in Jinja2 template cache
This commit is contained in:
Christian Krakau-Louis
2026-03-29 21:16:47 +02:00
committed by GitHub
2 changed files with 28 additions and 1 deletions
+1 -1
View File
@@ -345,7 +345,7 @@ async def settings_page(request: Request):
@app.get("/mail-sources", response_class=HTMLResponse)
async def mail_sources_page(request: Request):
return templates.TemplateResponse("mail_sources.html", {"request": request})
return templates.TemplateResponse(request, "mail_sources.html")
@app.get("/upload", response_class=HTMLResponse)
+27
View File
@@ -2,6 +2,7 @@
Tests for MailSource model and mail-sources API endpoints.
"""
import asyncio
from unittest.mock import MagicMock, patch
import pytest
@@ -494,6 +495,32 @@ class TestSourceToResponse:
assert response.password is None
# ---------------------------------------------------------------------------
# HTML page route mail_sources_page
# ---------------------------------------------------------------------------
def test_mail_sources_page_template_response():
"""Verify mail_sources_page uses the new-style TemplateResponse(request, name) API.
Regression test for the 500 error caused by the old-style
``TemplateResponse("mail_sources.html", {"request": request})`` call, which
passed a dict as the template name and triggered
``TypeError: unhashable type: 'dict'`` in Jinja2's LRU cache.
"""
from app.main import mail_sources_page # module-level route function
mock_request = MagicMock()
with patch("app.main.templates") as mock_templates:
mock_response = MagicMock()
mock_templates.TemplateResponse.return_value = mock_response
result = asyncio.run(mail_sources_page(mock_request))
mock_templates.TemplateResponse.assert_called_once_with(mock_request, "mail_sources.html")
assert result is mock_response
# ---------------------------------------------------------------------------
# Pytest marker to avoid warnings for test methods without assertions
# ---------------------------------------------------------------------------