gitea-admin/gh-christianlouis-docuelevate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #109 from christianlouis/copilot/fix-single-file-deletion-error

Browse Source 
Fix single file deletion by parsing JSON response before page reload
This commit is contained in:
Christian Krakau-Louis
2026-02-07 19:45:04 +01:00
committed by GitHub
parent 6592f57905 4c8ec85bfa
commit d1785c2d77
2 changed files with 108 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/templates/files.html
+6 -1
View File
@@ -501,8 +501,13 @@
})
.then(response => {
if (!response.ok) {
throw new Error('Failed to delete file');
return response.json().then(err => {
throw new Error(err.detail || 'Failed to delete file');
});
}
return response.json();
})
.then(data => {
// Reload the page to show updated file list
window.location.reload();
})
tests/test_bulk_operations.py
+102 -71
View File
@@ -1,17 +1,58 @@
"""
Tests for bulk file operations (delete and reprocess).
"""
import pytest
from fastapi.testclient import TestClient
from app.models import FileRecord, ProcessingLog
from unittest.mock import patch, MagicMock
@pytest.mark.integration
@pytest.mark.requires_db
class TestSingleFileOperations:
"""Tests for single file operations."""
def test_single_file_delete_success(self, client: TestClient, db_session):
"""Test deletion of a single file."""
# Create a sample file
file_record = FileRecord(
filehash="hash1",
original_filename="test.pdf",
local_filename="/tmp/test.pdf",
file_size=1024,
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.commit()
file_id = file_record.id
# Delete the file
response = client.delete(f"/api/files/{file_id}")
assert response.status_code == 200
data = response.json()
assert data["status"] == "success"
assert f"File record {file_id} deleted successfully" in data["message"]
# Verify file is deleted
file_record = (
db_session.query(FileRecord).filter(FileRecord.id == file_id).first()
)
assert file_record is None
def test_single_file_delete_nonexistent(self, client: TestClient, db_session):
"""Test deletion of a non-existent file."""
response = client.delete("/api/files/9999")
assert response.status_code == 404
data = response.json()
assert "not found" in data["detail"].lower()
@pytest.mark.integration
@pytest.mark.requires_db
class TestBulkOperations:
"""Tests for bulk file operations."""
def test_bulk_delete_success(self, client: TestClient, db_session):
"""Test bulk deletion of files."""
# Create sample files
@@ -22,54 +63,49 @@ class TestBulkOperations:
original_filename=f"test{i}.pdf",
local_filename=f"/tmp/test{i}.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.flush()
file_ids.append(file_record.id)
db_session.commit()
# Bulk delete
response = client.post(
"/api/files/bulk-delete",
json=file_ids
)
response = client.post("/api/files/bulk-delete", json=file_ids)
assert response.status_code == 200
data = response.json()
assert data["status"] == "success"
assert len(data["deleted_ids"]) == 3
# Verify files are deleted
for file_id in file_ids:
file_record = db_session.query(FileRecord).filter(FileRecord.id == file_id).first()
file_record = (
db_session.query(FileRecord).filter(FileRecord.id == file_id).first()
)
assert file_record is None
def test_bulk_delete_empty_list(self, client: TestClient, db_session):
"""Test bulk deletion with empty list."""
response = client.post(
"/api/files/bulk-delete",
json=[]
)
response = client.post("/api/files/bulk-delete", json=[])
assert response.status_code == 404
data = response.json()
assert "No files found" in data["detail"]
def test_bulk_delete_nonexistent_files(self, client: TestClient, db_session):
"""Test bulk deletion of non-existent files."""
response = client.post(
"/api/files/bulk-delete",
json=[9999, 9998]
)
response = client.post("/api/files/bulk-delete", json=[9999, 9998])
assert response.status_code == 404
@patch('app.api.files.process_document')
def test_bulk_reprocess_success(self, mock_process_document, client: TestClient, db_session):
@patch("app.api.files.process_document")
def test_bulk_reprocess_success(
self, mock_process_document, client: TestClient, db_session
):
"""Test bulk reprocessing of files."""
# Setup mock
mock_task = MagicMock()
mock_task.id = "test-task-id"
mock_process_document.delay.return_value = mock_task
# Create sample files with local files that "exist"
file_ids = []
for i in range(2):
@@ -78,68 +114,63 @@ class TestBulkOperations:
original_filename=f"test{i}.pdf",
local_filename=f"/tmp/test{i}.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.flush()
file_ids.append(file_record.id)
db_session.commit()
# Mock os.path.exists to return True
with patch('os.path.exists', return_value=True):
response = client.post(
"/api/files/bulk-reprocess",
json=file_ids
)
with patch("os.path.exists", return_value=True):
response = client.post("/api/files/bulk-reprocess", json=file_ids)
assert response.status_code == 200
data = response.json()
assert data["status"] == "success"
assert len(data["processed_files"]) == 2
assert len(data["task_ids"]) == 2
@patch('app.api.files.process_document')
def test_bulk_reprocess_missing_files(self, mock_process_document, client: TestClient, db_session):
@patch("app.api.files.process_document")
def test_bulk_reprocess_missing_files(
self, mock_process_document, client: TestClient, db_session
):
"""Test bulk reprocessing when some local files are missing."""
# Setup mock
mock_task = MagicMock()
mock_task.id = "test-task-id"
mock_process_document.delay.return_value = mock_task
# Create sample files
file_ids = []
for i in range(2):
file_record = FileRecord(
filehash=f"hash{i}",
original_filename=f"test{i}.pdf",
local_filename=f"/tmp/test{i}.pdf" if i == 0 else None, # Second file has no local file
local_filename=(
f"/tmp/test{i}.pdf" if i == 0 else None
), # Second file has no local file
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.flush()
file_ids.append(file_record.id)
db_session.commit()
# Mock os.path.exists to return False for missing file
with patch('os.path.exists', return_value=False):
response = client.post(
"/api/files/bulk-reprocess",
json=file_ids
)
with patch("os.path.exists", return_value=False):
response = client.post("/api/files/bulk-reprocess", json=file_ids)
assert response.status_code == 200
data = response.json()
# All files should have errors since we mocked exists to return False
assert data["errors"] is not None
assert len(data["errors"]) == 2
def test_bulk_reprocess_nonexistent_files(self, client: TestClient, db_session):
"""Test bulk reprocessing of non-existent files."""
response = client.post(
"/api/files/bulk-reprocess",
json=[9999, 9998]
)
response = client.post("/api/files/bulk-reprocess", json=[9999, 9998])
assert response.status_code == 404
@@ -147,7 +178,7 @@ class TestBulkOperations:
@pytest.mark.requires_db
class TestStatusFilter:
"""Tests for status filtering in files view."""
def test_status_filter_pending(self, client: TestClient, db_session):
"""Test filtering files by pending status."""
# Create files with different statuses
@@ -157,38 +188,38 @@ class TestStatusFilter:
original_filename="pending.pdf",
local_filename="/tmp/pending.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file1)
# File 2: Processing (has in_progress log)
file2 = FileRecord(
filehash="hash2",
original_filename="processing.pdf",
local_filename="/tmp/processing.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file2)
db_session.flush()
log2 = ProcessingLog(
file_id=file2.id,
task_id="task2",
step_name="OCR",
status="in_progress",
message="Processing..."
message="Processing...",
)
db_session.add(log2)
db_session.commit()
# Test pending filter
response = client.get("/files?status=pending")
assert response.status_code == 200
# Check that pending file is shown (HTML response)
assert "pending.pdf" in response.text
assert "processing.pdf" not in response.text
def test_status_filter_processing(self, client: TestClient, db_session):
"""Test filtering files by processing status."""
# Create file with in_progress status
@@ -197,26 +228,26 @@ class TestStatusFilter:
original_filename="processing.pdf",
local_filename="/tmp/processing.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.flush()
log = ProcessingLog(
file_id=file_record.id,
task_id="task1",
step_name="OCR",
status="in_progress",
message="Processing..."
message="Processing...",
)
db_session.add(log)
db_session.commit()
# Test processing filter
response = client.get("/files?status=processing")
assert response.status_code == 200
assert "processing.pdf" in response.text
def test_status_filter_completed(self, client: TestClient, db_session):
"""Test filtering files by completed status."""
# Create file with success status
@@ -225,26 +256,26 @@ class TestStatusFilter:
original_filename="completed.pdf",
local_filename="/tmp/completed.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.flush()
log = ProcessingLog(
file_id=file_record.id,
task_id="task1",
step_name="OCR",
status="success",
message="Completed"
message="Completed",
)
db_session.add(log)
db_session.commit()
# Test completed filter
response = client.get("/files?status=completed")
assert response.status_code == 200
assert "completed.pdf" in response.text
def test_status_filter_failed(self, client: TestClient, db_session):
"""Test filtering files by failed status."""
# Create file with failure status
@@ -253,21 +284,21 @@ class TestStatusFilter:
original_filename="failed.pdf",
local_filename="/tmp/failed.pdf",
file_size=1024,
mime_type="application/pdf"
mime_type="application/pdf",
)
db_session.add(file_record)
db_session.flush()
log = ProcessingLog(
file_id=file_record.id,
task_id="task1",
step_name="OCR",
status="failure",
message="Failed"
message="Failed",
)
db_session.add(log)
db_session.commit()
# Test failed filter
response = client.get("/files?status=failed")
assert response.status_code == 200